Skip to content

feat: release upgrading support #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
May 28, 2025
Merged

feat: release upgrading support #379

merged 19 commits into from
May 28, 2025

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented May 22, 2025 •
edited
Loading

Description

Implementation for #179

As explained here, Helm does not support upgrading CRDs, so the upgrade implementation in this PR mirrored the already described upgrade workflow from the release notes.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Documentation added or updated
- [x] Changelog updated

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@xeniape xeniape self-assigned this May 23, 2025
@xeniape xeniape marked this pull request as ready for review May 23, 2025 07:18
@xeniape xeniape linked an issue May 23, 2025 that may be closed by this pull request
Support upgrading from one release to another #179
Closed
@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering May 23, 2025
sbernauer
sbernauer reviewed May 23, 2025
View reviewed changes
NickLarsenNZ

This comment was marked as resolved.

Sign in to view

@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 26, 2025
@xeniape xeniape requested review from NickLarsenNZ and sbernauer May 27, 2025 08:06
NickLarsenNZ

This comment was marked as resolved.

Sign in to view

@xeniape xeniape requested a review from NickLarsenNZ May 27, 2025 08:10
NickLarsenNZ

This comment was marked as resolved.

Sign in to view

@NickLarsenNZ NickLarsenNZ mentioned this pull request May 27, 2025
Open
NickLarsenNZ
NickLarsenNZ requested changes May 27, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two more things

@xeniape xeniape requested a review from NickLarsenNZ May 27, 2025 18:09
NickLarsenNZ
NickLarsenNZ approved these changes May 27, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xeniape xeniape enabled auto-merge May 28, 2025 05:29
@xeniape xeniape added this pull request to the merge queue May 28, 2025
Merged via the queue into main with commit 3d373c0 May 28, 2025
29 of 31 checks passed
@xeniape xeniape deleted the feat/upgrading-support branch May 28, 2025 05:30
@lfrancke lfrancke moved this from Development: In Review to Development: Done in Stackable Engineering May 28, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

@sbernauer sbernauer Awaiting requested review from sbernauer

Assignees

@xeniape xeniape

Labels
None yet
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support upgrading from one release to another
3 participants
@xeniape @NickLarsenNZ @sbernauer