wip: support bzlmod

[pcj]

TODO

• fix proto_repository: gazelle is generating canonical repo names vs apparent repo names

diff --git a/example/thing/BUILD.bazel b/example/thing/BUILD.bazel
index eaf7597b..dabd0e39 100644
--- a/example/thing/BUILD.bazel
+++ b/example/thing/BUILD.bazel
@@ -13,7 +13,7 @@ proto_library(
     name = "thing_proto",
     srcs = ["thing.proto"],
     visibility = ["//visibility:public"],
-    deps = ["@protobufapis//google/protobuf:timestamp_proto"],
+    deps = ["@_main~proto_repository~protobufapis//google/protobuf:timestamp_proto"],
 )

• fix failing tests //cmd/gencopy:gencopy_test and //cmd/gazelle:gazelle_test
• migrate golden example tests to bzlmod
• lock @maven_akka
• update documentation
• bump version
• update github CI
• cleanup and organize MODULE.bazel
• ? remove depsgen (vs wait until WORKSPACE.bzlmod is empty)

//cmd/gazelle/internal/wspace:wspace_test                       (cached) PASSED in 0.3s
//example/routeguide/closure:client_test                                 PASSED in 18.5s
//pkg/language/protobuf:protobuf_test                                    PASSED in 0.3s
//pkg/plugin/akka/akka_grpc:akka_grpc_test                               PASSED in 0.4s
//pkg/plugin/bufbuild:bufbuild_test                                      PASSED in 0.5s
//pkg/plugin/builtin:builtin_test                                        PASSED in 6.8s
//pkg/plugin/golang/protobuf:protobuf_test                               PASSED in 0.6s
//pkg/plugin/grpc/grpc:bazel_test                                        PASSED in 2.8s
//pkg/plugin/grpc/grpc:grpc_test                                         PASSED in 11.5s
//pkg/plugin/grpcecosystem/grpcgateway:grpcgateway_test                  PASSED in 0.6s
//pkg/plugin/scalapb/scalapb:scalapb_test                                PASSED in 0.7s
//pkg/plugin/stephenh/ts-proto:ts-proto_test                             PASSED in 0.6s
//pkg/protoc:protoc_test                                                 PASSED in 0.5s
//pkg/rule/rules_go:rules_go_test                                        PASSED in 0.3s
//pkg/rule/rules_python:rules_python_test                                PASSED in 0.3s
//pkg/rule/rules_scala:rules_scala_test                                  PASSED in 0.3s
//cmd/gencopy:gencopy_test                                               FAILED in 0.3s
  /private/var/tmp/_bazel_pcj/092d6dadaf86f07590903c45033f576e/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/cmd/gencopy/gencopy_test/test.log
//example/golden:closurejs_test                                          FAILED in 0.1s
  /private/var/tmp/_bazel_pcj/092d6dadaf86f07590903c45033f576e/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/example/golden/closurejs_test/test.log
//example/golden:commonjs_test                                           FAILED in 0.2s
  /private/var/tmp/_bazel_pcj/092d6dadaf86f07590903c45033f576e/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/example/golden/commonjs_test/test.log
//example/golden:cpp_test                                                FAILED in 0.2s
  /private/var/tmp/_bazel_pcj/092d6dadaf86f07590903c45033f576e/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/example/golden/cpp_test/test.log
//example/golden:csharp_test                                             FAILED in 0.1s
  /private/var/tmp/_bazel_pcj/092d6dadaf86f07590903c45033f576e/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/example/golden/csharp_test/test.log
//example/golden:go_test                                                 FAILED in 0.2s
  /private/var/tmp/_bazel_pcj/092d6dadaf86f07590903c45033f576e/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/example/golden/go_test/test.log
//example/golden:goembed_test                                            FAILED in 0.2s
  /private/var/tmp/_bazel_pcj/092d6dadaf86f07590903c45033f576e/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/example/golden/goembed_test/test.log
//example/golden:gogo_test                                               FAILED in 0.2s
  /private/var/tmp/_bazel_pcj/092d6dadaf86f07590903c45033f576e/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/example/golden/gogo_test/test.log
//example/golden:golden_test                                             FAILED in 2.2s
  /private/var/tmp/_bazel_pcj/092d6dadaf86f07590903c45033f576e/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/example/golden/golden_test/test.log
//example/golden:gomerge_test                                            FAILED in 0.1s
  /private/var/tmp/_bazel_pcj/092d6dadaf86f07590903c45033f576e/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/example/golden/gomerge_test/test.log
//example/golden:java_test                                               FAILED in 0.2s
  /private/var/tmp/_bazel_pcj/092d6dadaf86f07590903c45033f576e/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/example/golden/java_test/test.log
//example/golden:objc_test                                               FAILED in 0.2s
  /private/var/tmp/_bazel_pcj/092d6dadaf86f07590903c45033f576e/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/example/golden/objc_test/test.log
//example/golden:proto_compiled_sources_test                             FAILED in 0.2s
  /private/var/tmp/_bazel_pcj/092d6dadaf86f07590903c45033f576e/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/example/golden/proto_compiled_sources_test/test.log
//example/golden:proto_repository_test                                   FAILED in 0.2s
  /private/var/tmp/_bazel_pcj/092d6dadaf86f07590903c45033f576e/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/example/golden/proto_repository_test/test.log
//example/golden:python_test                                             FAILED in 0.2s
  /private/var/tmp/_bazel_pcj/092d6dadaf86f07590903c45033f576e/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/example/golden/python_test/test.log
//example/golden:ruby_test                                               FAILED in 0.2s
  /private/var/tmp/_bazel_pcj/092d6dadaf86f07590903c45033f576e/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/example/golden/ruby_test/test.log
//example/golden:scala_test                                              FAILED in 0.3s
  /private/var/tmp/_bazel_pcj/092d6dadaf86f07590903c45033f576e/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/example/golden/scala_test/test.log
//example/golden:starlark_java_test                                      FAILED in 0.1s
  /private/var/tmp/_bazel_pcj/092d6dadaf86f07590903c45033f576e/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/example/golden/starlark_java_test/test.log
//example/golden:strip_import_prefix_test                                FAILED in 0.1s
  /private/var/tmp/_bazel_pcj/092d6dadaf86f07590903c45033f576e/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/example/golden/strip_import_prefix_test/test.log
//example/toolchain/prebuilt:prebuilt_test                               FAILED in 0.1s
  /private/var/tmp/_bazel_pcj/092d6dadaf86f07590903c45033f576e/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/example/toolchain/prebuilt/prebuilt_test/test.log
//example/toolchain/standard:standard_test                               FAILED in 0.1s
  /private/var/tmp/_bazel_pcj/092d6dadaf86f07590903c45033f576e/execroot/_main/bazel-out/darwin_arm64-fastbuild/testlogs/example/toolchain/standard/standard_test/test.log

Fixes #319

[jvolkman]

go_sdk needs to be marked as a dev dependency.

[mpatou-openai]

Tried this branch with the fix of @jvolkman and it works perfectly for our needs (python, go and java protobuf + grpc)

[cristifalcas]

any plans to move this forward? I'm also interested to see this merged at some point

[darkrift]

@pcj Any plan to move forward with this ?

[pcj]

Yes, need to fix up a few things and get this merged. Thanks for the ping.

[darkrift]

Yes, need to fix up a few things and get this merged. Thanks for the ping.

Notably Scala and closure are in the BCR now, haven't checked the others in the workspace.bzlmod file

[darkrift]

I also tried this as a patch in bb-portal for the frontend portion (along with the go_sdk dev_dependency fix and adding the override for protobuf_javascript) but getting the following error :

ERROR: error loading package '@@build_stack_rules_proto+//': Unable to find package for @@[unknown repo '' requested from @@build_stack_rules_proto+]//rules:proto_gazelle.bzl: The repository '@@[unknown repo '' requested from @@build_stack_rules_proto+]' could not be resolved: No repository visible as '@' from repository '@@build_stack_rules_proto+'.
ERROR: /private/var/tmp/_bazel_rlavoie/c59bc87d81fae32b537a051e9ee7535b/external/build_stack_rules_proto+/plugin/stephenh/ts-proto/BUILD.bazel:4:36: error loading package '@@build_stack_rules_proto+//': Unable to find package for @@[unknown repo '' requested from @@build_stack_rules_proto+]//rules:proto_gazelle.bzl: The repository '@@[unknown repo '' requested from @@build_stack_rules_proto+]' could not be resolved: No repository visible as '@' from repository '@@build_stack_rules_proto+'. and referenced by '@@build_stack_rules_proto+//plugin/stephenh/ts-proto:ts-proto'

Here's the build file I am adding here:

load("@aspect_rules_ts//ts:proto.bzl", "ts_proto_library")
load("@build_stack_rules_proto//rules:proto_compile.bzl", "proto_compile")
load("@rules_proto//proto:defs.bzl", "proto_library")

proto_library(
    name = "resource_usage_proto",
    srcs = [":resourceusage.proto"],
    visibility = ["//visibility:public"],
    deps = [
        "@protobuf//:duration_proto",
    ],
)

proto_compile(
    name = "resource_usage_proto_ts_compile",
    outputs = [
        "person.pb.ts",
    ],
    plugins = ["@build_stack_rules_proto//plugin/stephenh/ts-proto:protoc-gen-ts-proto"],
    proto = "resource_usage_proto",
)

[pcj]

Closing in favor of #389