revamp of adding type hints for SQLAlchemy models #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CristhianMotoche
commented
Oct 3, 2024
CristhianMotoche
commented
- chore: Set up environment
- chore: Set up deps
- chore: Define model
- chore: Connect with App and get simple form
- chore: Install pyright
javoweb
reviewed
Oct 8, 2024
javoweb
left a comment
javoweb
left a comment
There was a problem hiding this comment.
Hey @CristhianMotoche. This one looks great! I left some minor suggestions. Please take them a look. :)
Comment on lines
+64
to
+66
| reveal_type(get_all) | ||
|
|
||
| reveal_type(get_unread) |
There was a problem hiding this comment.
We might want to wrap these reveal_type calls in an if TYPE_CHECKING: conditional to avoid runtime errors. WDYT?
Suggested change
| reveal_type(get_all) | |
| reveal_type(get_unread) | |
| if TYPE_CHECKING: | |
| reveal_type(get_all) | |
| reveal_type(get_unread) |
| ## Start | ||
|
|
||
| ``` | ||
| devenv shell |
There was a problem hiding this comment.
We might want to add a classical requirements.txt flow for non-Nix users. WDYT?
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| if len(sys.argv) > 1 and sys.argv[1] == 'db': |
There was a problem hiding this comment.
Should we add instructions about this in the README?
There was a problem hiding this comment.
Do we need this file in the repository?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.