-
-
Notifications
You must be signed in to change notification settings - Fork 135
adding profile share button #2576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meant to request changes, you can boil this down to a bunch of lines
components/user-header.js
Outdated
| } | ||
| } | ||
|
|
||
| const referrurl = (ipath, me, isMobile = false) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repeats what is already done in the Share component and share function, kewl name though
|
It's pretty good, I don't know how to feel about the icon in the dropdown but it's okay. |
|
okok i get the point, i'll try a different idea |
1 similar comment
|
okok i get the point, i'll try a different idea |




Description
fix #2573
Added a profile sharing feature that allows users to share profile links across all platforms.
/r/{username}) only when sharing via mobile Web Share APIScreenshots
Additional Context
The implementation reuses existing share infrastructure from
share.jsfor consistencyChecklist
Are your changes backward compatible? Please answer below:
Yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
7/10
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
Yes
Did you introduce any new environment variables? If so, call them out explicitly here:
NaN
Did you use AI for this? If so, how much did it assist you?
i used AI to check if a share-logic was already implemented