fix(Mention): Maintain mention after nym change #2591
+68
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing nym should still point to the user mentioned instead of losing link.
fixes #2232
Screenshots
Screen.Recording.2025-09-30.at.16.55.04.mov
Checklist
Are your changes backward compatible? Please answer below:
Y
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
8
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
Y
Did you introduce any new environment variables? If so, call them out explicitly here:
N
Did you use AI for this? If so, how much did it assist you?
Y? but the AI suggestions required DB changes even though all we needed was already in the DB. Maybe more premium models would've come up with something better. So I just worked out this solution.
Note
Resolve mentions to the correct user even after username changes by adding
userByMentionGraphQL query and wiring frontend mention/popover to use it withitemId.Query.userByMention(name: String!, itemId: ID): Userwith resolver that resolves a user fromMentionrecords for a givenitemId, falling back touser(name).components/text.js: PassitemIdintomentionrenderer andUserPopover; dynamically link mentions to/${user.name}when resolved. UpdateuseMemodeps to includeitemId.components/user-popover.js: QueryUSER_BY_MENTION(whenitemIdprovided) and fall back toUSER; expose resolved user to children; refine loading and display logic.USER_BY_MENTIONquery infragments/users.js.Written by Cursor Bugbot for commit 0f58cd2. This will update automatically on new commits. Configure here.