refactor: convert WebLnProvider into hook #2598
Merged
+7
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of using a component that only uses
useEffectto hook into WebLN events from the browser extension, we can just calluseEffectin a custom hook like we already do for other hooks.Additional context
This is targeting thewalletsbranch instead ofmaster, because the changes here depend on the changes inwalletsthat have not been merged yet intomaster(#2572).I did not want to port the code back tomastersince it's not that important so I'd rather just not have to resolve a conflict later.Checklist
Are your changes backward compatible? Please answer below:
yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
8. WebLN wallet still disabled when lightning browser extension is disabledFor frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
no
Did you use AI for this? If so, how much did it assist you?
no
Note
Convert the
WebLnProvidercomponent into auseWeblnEventshook and wire it into global wallet hooks, removing the provider wrapper.WebLnProviderusage inwallets/client/hooks/global.jswithuseWeblnEvents()insideWalletHooks, removing the provider wrapper around children.WebLnProviderto hookuseWeblnEventsinwallets/lib/protocols/webln.jsto managewebln:enabled/disabledevents and setwindow.weblnEnabledforisAvailable.Written by Cursor Bugbot for commit 1614dd9. This will update automatically on new commits. Configure here.