Adds nova-compute drain role #6
Conversation
A utility role to migrate VMs from hypervisors.
jovial
force-pushed
the
feature/compute-drain
branch
from
e8dbebd to
a874cf3
Compare
jovial
force-pushed
the
feature/compute-drain
branch
from
a874cf3 to
4e050f4
Compare
| @@ -0,0 +1,4 @@ | |||
| --- | |||
|
|
|||
| nova_compute_drain_venv: "{{ virtualenv_path }}/openstack" | |||
There was a problem hiding this comment.
virtualenv_path is defined by kayobe. Should I add some default here? Something in the home directory maybe?
There was a problem hiding this comment.
Yeah that would be a better default
| --- | ||
|
|
||
| nova_compute_drain_venv: "{{ virtualenv_path }}/openstack" | ||
| nova_compute_drain_delegate_host: "{{ groups['controllers'][0] }}" |
There was a problem hiding this comment.
Default doesn't make sense outside kayobe
| @@ -0,0 +1,4 @@ | |||
| --- | |||
|
|
|||
| nova_compute_drain_venv: "{{ virtualenv_path }}/openstack" | |||
There was a problem hiding this comment.
Yeah that would be a better default
| --- | ||
|
|
||
| nova_compute_drain_venv: "{{ virtualenv_path }}/openstack" | ||
| nova_compute_drain_delegate_host: "{{ groups['controllers'][0] }}" |
| virtualenv: "{{ nova_compute_drain_venv }}" | ||
| name: | ||
| - python-openstackclient | ||
| extra_args: "{% if pip_upper_constraints_file %}-c {{ pip_upper_constraints_file }}{% endif %}" |
There was a problem hiding this comment.
| extra_args: "{% if pip_upper_constraints_file %}-c {{ pip_upper_constraints_file }}{% endif %}" | |
| extra_args: "{% if nova_compute_drain_upper_constraints_file %}-c {{ nova_compute_drain_upper_constraints_file }}{% endif %}" |
And add to defaults?
| - pip | ||
| - setuptools | ||
| state: latest | ||
| virtualenv_command: /usr/bin/python3.6 -m venv |
There was a problem hiding this comment.
| virtualenv_command: /usr/bin/python3.6 -m venv | |
| virtualenv_command: /usr/bin/python3 -m venv |
| vars: | ||
| # NOTE: Without this, the delegate ansible_host variable will not | ||
| # be respected when using delegate_to. | ||
| ansible_host: "{{ hostvars[nova_compute_drain_delegate_host].ansible_host | default(nova_compute_drain_delegate_host) }}" |
| @@ -0,0 +1,17 @@ | |||
| --- | |||
|
|
|||
| - name: "Live migrate instance: {{ instance_uuid }}" # noqa no-changed-when | |||
There was a problem hiding this comment.
Add changed_when: true, remove noqa
| --- | ||
|
|
||
| - block: | ||
| - name: "Cold migrate instance: {{ instance_uuid }}" # noqa no-changed-when |
There was a problem hiding this comment.
Add changed_when: true, remove noqa
| retries: 10 | ||
| delay: 30 | ||
|
|
||
| - name: "Confirm resize: {{ instance_uuid }}" # noqa no-changed-when |
There was a problem hiding this comment.
Add changed_when: true, remove noqa
| vars: | ||
| ansible_host: "{{ hostvars[nova_compute_drain_delegate_host].ansible_host }}" | ||
| rescue: | ||
| - meta: noop # noqa unnamed-task |
There was a problem hiding this comment.
Could use a comment to explain why we're ignoring errors here.
| @@ -0,0 +1,17 @@ | |||
| --- | |||
|
|
|||
There was a problem hiding this comment.
Do we need to ignore errors here, or is it an async API that does not generally fail?
A utility role to migrate VMs from hypervisors.