Add neutron-namespace-drain role #9
Conversation
assumptionsandg
force-pushed
the
feature/neutron-namespace-drain
branch
3 times, most recently
from
5ac4e3e to
7bfb233
Compare
assumptionsandg
force-pushed
the
feature/neutron-namespace-drain
branch
from
7bfb233 to
7cc3696
Compare
| ansible.builtin.command: > | ||
| {{ neutron_namespace_drain_venv }}/bin/openstack | ||
| network agent list --host {{ neutron_namespace_drain_host }} | ||
| --agent-type dhcp -f value -c ID | ||
| register: src_dhcp_id | ||
| environment: "{{ openstack_auth_env }}" | ||
| changed_when: false | ||
| delegate_to: "{{ neutron_namespace_drain_host }}" | ||
| vars: | ||
| ansible_host: "{{ hostvars[neutron_namespace_drain_host].ansible_host }}" |
There was a problem hiding this comment.
Does this command have to be run from the host it is targetting? If not, I'm not sure that neutron_namespace_drain_host should refer both to the host being drained and the host that the commands are running from. If you want to default them to the same thing that's fine, but it would be nice if we could specify where we run openstack commands as a separate host
There was a problem hiding this comment.
I see what you're saying and I don't see any reason for these commands to be run from the same host really, though I'm not sure if they're any implications to running it on localhost or whatever. I think we should set a new delegate_to var neutron_namespace_drain_play_host default to the namespace drain host, and potentially change it to something else after testing.
| with_items: | ||
| - "{{ router_ids }}" | ||
|
|
||
| - name: Wait for no more routers to be attached to the host |
| - name: Add agents to router | ||
| ansible.builtin.include_tasks: add-new-l3.yml | ||
| when: router_ids | length > 0 |
There was a problem hiding this comment.
Shouldn't this be "Add router to agents"?
|
Changes paused until Arcus prod upgrade finishes. |
|
@assumptionsandg what's the timeline on the upgrade? |
|
@assumptionsandg prod upgrade is done now |
Co-authored-by: Alex Welsh <[email protected]>
removed merge conflict
become root for query source task
No description provided.