Skip to content

Changing the IPA compression algorithm and updating the IPA image tag to use new compressed images #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: stackhpc/2025.1
Choose a base branch
from
Open

Changing the IPA compression algorithm and updating the IPA image tag to use new compressed images #1912

wants to merge 1 commit into from

Conversation

@claudia-lola
Copy link

Updates the IPA (Ironic Python Agent) compression algorithm from the default gzip to use instead zstd -19. This change will reduce the transfer size of the IPA boot ISO from the Ironic conductor to the baremetal nodes during provisioning. The IPA image tag has been updated to reference the new compressed IPA images.

@claudia-lola claudia-lola requested a review from a team as a code owner September 25, 2025 12:18
gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 25, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Ironic Python Agent (IPA) image compression to use zstd for smaller image sizes, and updates the corresponding image tags. The changes are straightforward and correctly implement the switch to zstd compression. I have one minor suggestion in etc/kayobe/ipa.yml to improve the conciseness of the command. Also, there's a small typo ('alogrithm') in the pull request title.

@Alex-Welsh
Copy link
Member

@claudia-lola the IPA images were just rebuilt and updated in another PR: #1909

Could you please rebase your changes on the latest version of stackhpc/2025.1, then rebuild the images and update the tags?

Also, this change needs a release note.

If you need a hand with any of that, just let me know

assumptionsandg
assumptionsandg reviewed Oct 29, 2025
View reviewed changes
Copy link
Contributor

@assumptionsandg assumptionsandg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should just backport https://review.opendev.org/c/openstack/kayobe/+/962285 to our downstream Kayobe fork instead of making the change here?

@claudia-lola
adding DIB_IPA_COMPRESS_CMD to ipa.yml
184145f 
removed '--compress'

release note added

add TODO to remove DIB_IPA_COMPRESS_CMD
assumptionsandg
assumptionsandg approved these changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@assumptionsandg assumptionsandg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this instead of the backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assumptionsandg assumptionsandg assumptionsandg approved these changes

@mnasiadka mnasiadka Awaiting requested review from mnasiadka

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

@claudia-lola claudia-lola

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@claudia-lola @Alex-Welsh @priteau @mnasiadka @assumptionsandg