Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ske kubeconfig create. merge kubeconfig into the default kubeconfig file #556 #557

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

fjvela
Copy link

@fjvela fjvela commented Jan 12, 2025

The PR changes the default behaivor of the command ´ske kubeconfig create´: the kubeconfig information of the SKE cluster is merged into the default kubeconfig file of the current user. If the kubeconfig file doesn't exist, a new one will be created.

#556

@fjvela fjvela force-pushed the kubeconfig-merge branch 2 times, most recently from 3473f60 to c0cb4eb Compare January 13, 2025 17:12
Copy link

@hown3d hown3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, really appreciate it!
Just some nits :)

internal/pkg/services/ske/utils/utils.go Show resolved Hide resolved
internal/pkg/services/ske/utils/utils.go Outdated Show resolved Hide resolved
@fjvela fjvela force-pushed the kubeconfig-merge branch 2 times, most recently from a4e33a2 to bfedf22 Compare January 16, 2025 17:47
@fjvela fjvela requested review from marceljk and hown3d January 16, 2025 17:47
internal/cmd/ske/kubeconfig/create/create.go Outdated Show resolved Hide resolved
internal/cmd/ske/kubeconfig/create/create.go Outdated Show resolved Hide resolved
internal/cmd/ske/kubeconfig/create/create.go Outdated Show resolved Hide resolved
internal/cmd/ske/kubeconfig/create/create.go Show resolved Hide resolved
internal/cmd/ske/kubeconfig/create/create_test.go Outdated Show resolved Hide resolved
@fjvela fjvela requested a review from marceljk January 17, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants