Skip to content

fix: replaced deprecated brews config in goreleaser #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 27 additions & 6 deletions .goreleaser.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ builds:
- amd64
hooks:
post:
# Signing
- cmd: codesign -s "{{.Env.APPLE_APPLICATION_IDENTITY}}" -f -v --options=runtime "dist/macos-builds_{{.Target}}/{{.Name}}"
output: true
- cmd: codesign -vvv --deep --strict "dist/macos-builds_{{.Target}}/{{.Name}}"
Expand All @@ -46,12 +47,29 @@ builds:
output: true
- cmd: spctl -a -t open --context context:primary-signature -v dist/{{ .ProjectName }}_{{ .Version }}_{{ .Os }}_{{ .Arch }}.dmg
output: true
# Completion files
- cmd: mkdir -p dist/macos-builds_{{.Target}}/completions
- cmd: sh -c './dist/macos-builds_{{.Target}}/{{.Name}} completion zsh > ./dist/macos-builds_{{.Target}}/completions/stackit.zsh'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need the sh -c here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it first without sh -c but then it doesn't pipe the content into the files. And with adding sh -c it works

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try this one?

Suggested change
- cmd: sh -c './dist/macos-builds_{{.Target}}/{{.Name}} completion zsh > ./dist/macos-builds_{{.Target}}/completions/stackit.zsh'
- cmd: "./dist/macos-builds_{{.Target}}/{{.Name}} completion zsh > ./dist/macos-builds_{{.Target}}/completions/stackit.zsh"

- cmd: sh -c './dist/macos-builds_{{.Target}}/{{.Name}} completion bash > ./dist/macos-builds_{{.Target}}/completions/stackit.bash'
- cmd: sh -c './dist/macos-builds_{{.Target}}/{{.Name}} completion fish > ./dist/macos-builds_{{.Target}}/completions/stackit.fish'

archives:
- formats: [ 'tar.gz' ]
- ids:
- linux-builds
- windows-builds
formats: [ 'tar.gz' ]
format_overrides:
- goos: windows
formats: [ 'zip' ]
- id: macos-archives
ids:
- macos-builds
formats: [ 'tar.gz' ]
files:
- src: ./dist/macos-builds_{{.Target}}/completions/*
dst: completions
- LICENSE.md
- README.md

release:
# If set to auto, the GitHub release will be marked as "Pre-release"
Expand Down Expand Up @@ -96,8 +114,11 @@ signs:
"${artifact}",
]

brews:
homebrew_casks:
- name: stackit
directory: Casks
conflicts:
- formula: stackit
repository:
owner: stackitcloud
name: homebrew-tap
Expand All @@ -106,14 +127,14 @@ brews:
email: [email protected]
homepage: "https://github.com/stackitcloud/stackit-cli"
description: "A command-line interface to manage STACKIT resources.\nThis CLI is in a beta state. More services and functionality will be supported soon."
directory: Formula
license: "Apache-2.0"
# If set to auto, the release will not be uploaded to the homebrew tap repo
# if the tag has a prerelease indicator (e.g. v0.0.1-alpha1)
skip_upload: auto
install: |
bin.install "stackit"
generate_completions_from_executable(bin/"stackit", "completion")
completions:
zsh: ./completions/stackit.zsh
bash: ./completions/stackit.bash
fish: ./completions/stackit.fish

snapcrafts:
# IDs of the builds for which to create packages for
Expand Down
Loading