Skip to content

Conversation

h3adex
Copy link
Contributor

@h3adex h3adex commented Sep 22, 2025

Description

This PR makes working with the datasource easier. Current way to work with it to enable stackit acls for stackit public ranges is this way:

data "stackit_public_ip_ranges" "this" {}

# old way
locals {
  stackit_services_cidrs = [for ip in data.stackit_public_ip_ranges.this.public_ip_ranges : ip.cidr]
}

# improved through pr
data.stackit_public_ip_ranges.this.cidr_list

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@h3adex h3adex requested a review from a team as a code owner September 22, 2025 12:04
@h3adex h3adex force-pushed the feat/add-reabable-ip-list branch 6 times, most recently from 4adaf65 to 2eb6163 Compare September 22, 2025 13:31
@rubenhoenle
Copy link
Member

@h3adex Thanks for the contribution! Can you maybe also adjust the acc tests for this?

@h3adex h3adex force-pushed the feat/add-reabable-ip-list branch from 2eb6163 to e8a0d8c Compare September 22, 2025 14:43
@h3adex
Copy link
Contributor Author

h3adex commented Sep 22, 2025

E2E Tests
Screenshot 2025-09-22 at 16 44 31

@h3adex h3adex force-pushed the feat/add-reabable-ip-list branch from e8a0d8c to 4c00380 Compare September 26, 2025 12:56
Copy link

github-actions bot commented Oct 4, 2025

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions bot added the Stale PR is marked as stale due to inactivity. label Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale PR is marked as stale due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants