Add recovery package with panic recovery middleware - #10
Merged
Conversation
Add the recovery package which provides HTTP middleware that recovers from panics and returns a 500 Internal Server Error response. This prevents individual panicking requests from crashing the server. The package is extracted from toolhive/pkg/recovery with adaptations: - Removed toolhive-specific dependencies (logger, transport/types) - Removed factory pattern types (too coupled to toolhive internals) - Added TODO referencing #7 for future logging support Logging support will be added once common logging is established across the ToolHive ecosystem. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jhrozek
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recoverypackage providing HTTP middleware that recovers from panicstoolhive/pkg/recoveryas part of THV-0032 (Tier 1 graduation)Components
doc.gorecovery.goMiddlewarefunction for panic recoveryrecovery_test.goChanges from Original
pkg/loggerdependency (toolhive's zap logger)pkg/transport/typesdependency (factory pattern)Logging Deferred
Logging support is intentionally deferred until common logging is established across ToolHive. See #7 for tracking.
Test Plan
task test)task lint)task license-check)🤖 Generated with Claude Code