Add Environment field to BaseConfig - #182
Closed
reyortiz3 wants to merge 1 commit into
Closed
Conversation
Several services independently reimplement dev/staging/prod as a freeform string (Sentry config, ai-gateway's TLS gating), with no shared validation. Give BaseConfig a validated Environment enum instead so gating logic can rely on a known-good value rather than a matched-nowhere-else string. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Author
|
Consolidating into #181 instead of stacking — the Environment commit has been cherry-picked onto add-base-config-package directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Environmentenum (development/staging/production) toBaseConfig, required alongsideServiceName.configpackage this depends on) — targets that branch rather thanmain.Test plan
task lint— cleantask test— full repo passes, including newEnvironment.Valid()table tests and updatedBaseConfig.Validate()cases (missing/unknown environment)task license-check— cleanTestLoad_ExtendedServiceConfigextended to cover a YAMLenvironment:field end-to-end🤖 Generated with Claude Code