Skip to content

Relax pre-release go-sdk release guard to a warning #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JAORMX merged 1 commit into from
Jul 28, 2026
Merged

Relax pre-release go-sdk release guard to a warning #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ jobs:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

# toolhive-core is a shared library: a pre-release go-sdk require
# propagates to every downstream consumer via MVS. Fail the release
# job so nobody accidentally tags a release pinned to a go-sdk
# pre-release (see the inline comment on the go-sdk require in go.mod).
# propagates to every downstream consumer via MVS. Warn on release so
# it's obvious a go-sdk pre-release is pinned (see the inline comment
# on the go-sdk require in go.mod), without blocking releases needed
# before go-sdk v1.7.0 final ships.
- name: Guard against pre-release go-sdk dependency
run: |
if grep -qE 'github\.com/modelcontextprotocol/go-sdk v[0-9]+\.[0-9]+\.[0-9]+-(pre|rc)' go.mod; then
echo "::error file=go.mod::go.mod pins a pre-release go-sdk version; do not tag a toolhive-core release until go-sdk final ships"
echo "::warning file=go.mod::go.mod pins a pre-release go-sdk version; confirm this release is intentional before go-sdk final ships"
grep -nE 'github\.com/modelcontextprotocol/go-sdk v[0-9]+\.[0-9]+\.[0-9]+-(pre|rc)' go.mod
exit 1
fi

- name: Upload schema artifacts to release
Expand Down