feat: add existing server to existing group #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kantord
changed the title
- Implement AddServerToGroupMenuItem component with dropdown support - Enhance generateSimplePrompt to handle dropdown options - Add comprehensive test for the complete workflow - Fix linting errors by replacing 'any' types with proper TypeScript types - Use existing 'groups' feature flag for feature gating - Ready for backend integration when API is available
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to copy existing MCP servers to existing groups through a context menu option. Users can now right-click on any server card and select "Copy server to a group" to duplicate the server configuration into a selected destination group.
- Adds a context menu item for copying servers to groups
- Implements server-to-group copy functionality with API integration
- Enhances the prompt system to support dropdown selection
- Adds comprehensive test coverage for the new workflow
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
vitest.setup.ts |
Adds pointer capture mock functions for UI testing |
use-mutation-update-workload-group.ts |
New hook implementing server copy-to-group mutation logic |
use-groups.ts |
New hook for fetching available groups data |
groups-manager/index.tsx |
Refactors to use centralized groups hook |
card-mcp-server.tsx |
Adds copy-to-group menu item to server cards |
add-server-to-group-menu-item.tsx |
New component for the copy-to-group menu item |
card-mcp-server.test.tsx |
Adds comprehensive tests for the new functionality |
handlers.ts |
Adds mock handler for workload export endpoint |
servers.ts |
Adds test server fixture data |
use-prompt.tsx |
Enhances prompt system with dropdown selection support |
use-prompt.test.tsx |
Tests for new dropdown prompt functionality |
renderer/src/features/mcp-servers/components/add-server-to-group-menu-item.tsx
Show resolved
Hide resolved
renderer/src/features/mcp-servers/components/add-server-to-group-menu-item.tsx
Show resolved
Hide resolved
…up-menu-item.tsx Co-authored-by: Copilot <[email protected]>
|
💩 everything is failing now that I accepted the suggestion by github copilot ahahah let me fix that edit: pushed a fix |
…r-to-group-menu-item.tsx" This reverts commit 1624a4d.
peppescg
reviewed
Sep 3, 2025
renderer/src/features/mcp-servers/components/add-server-to-group-menu-item.tsx
Show resolved
Hide resolved
peppescg
reviewed
Sep 3, 2025
peppescg
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record_select-area_20250903153636.mp4