-
Notifications
You must be signed in to change notification settings - Fork 122
MCPRegistry e2e tests #2017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCPRegistry e2e tests #2017
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2017 +/- ##
==========================================
- Coverage 48.64% 48.52% -0.12%
==========================================
Files 240 240
Lines 30264 30344 +80
==========================================
+ Hits 14721 14725 +4
- Misses 14439 14504 +65
- Partials 1104 1115 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I've added more tests covering most of the sync, data sources and filtering options and workflows. |
- Create Ginkgo-based test suite for operator testing - Add comprehensive test helpers for MCPRegistry operations - Include test fixtures with sample YAML manifests - Set up Kubernetes test environment with envtest support - Add namespace isolation and cleanup utilities 🤖 Generated with [Claude Code](https://claude.ai/code) Signed-off-by: Daniele Martinoli <[email protected]> Co-authored-by: Claude <[email protected]>
- Create test suite with proper Kubernetes environment setup - Add specialized helper utilities for MCPRegistry operations - Implement ConfigMap test helpers for registry data validation - Add status validation helpers for phase and condition checking - Create timing utilities with proper timeout configurations - Add test data factories for generating test resources - Include builder patterns for fluent resource construction - Support both ToolHive and upstream MCP registry formats - Add comprehensive test fixtures and scenarios 🤖 Generated with [Claude Code](https://claude.ai/code) Signed-off-by: Daniele Martinoli <[email protected]> Co-authored-by: Claude <[email protected]>
- Fix finalizer removal using Patch instead of Update to avoid resource conflicts - Update registry data structure to match expected schema (add required fields: tier, status, tools, image) - Add proper registry deletion waiting in cleanup to prevent namespace deletion issues - Fix lint errors by removing dot imports from non-test files - Add comprehensive MCPRegistry lifecycle test coverage - Improve error handling and logging in test helpers Signed-off-by: Daniele Martinoli <[email protected]> Co-authored-by: Claude <[email protected]> 🤖 Generated with [Claude Code](https://claude.ai/code)
… errors) Signed-off-by: Daniele Martinoli <[email protected]>
… correct initial status" Signed-off-by: Daniele Martinoli <[email protected]>
- Introduced environment variable handling for KUBEBUILDER_ASSETS - Added warning for missing kubebuilder assets to improve test reliability - Updated test environment configuration to include BinaryAssetsDirectory This change aims to streamline the e2e testing process and provide clearer feedback on asset availability. Signed-off-by: Daniele Martinoli <[email protected]>
- initial draft of e2e tests Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
47860dd
to
ec329d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was mostly focusing on the controller changes which look good with one question about the has. In the test code, the question is just whether we want to remove some of the unused code or whether you want to keep it for later.
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I acked this patch if you want to merge now - I know on Slack you said you also want to integrate with Taskfile targets, but let me know if this should be done later.
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
…ciliation and avoid errors due to updated resource. - reviewed overall status calculation to consider updates or (if nil) lates status Signed-off-by: Daniele Martinoli <[email protected]>
all tests passed @jhrozek |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
epic! Let's merge
First bunch of tests to address #1749
It also depends on #2016 which should be committed first
test/e2e/operator/registry_lifecycle_test.go
initial test to prove the capabilities ofginkgo
as the testing framework for orchestrated workflowsQuestions to be answered:
operator-e2e-test
task?