moves heavyweight mcpgroup e2e tests to integration tests #2594
+259
−203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently have mcpgroup e2e tests that only verify that certain conditions are set when CRDs are applied. These are perfect for integration tests as it doesn't need the full cluster setup. Signed-off-by: ChrisJBurns <[email protected]>
Signed-off-by: ChrisJBurns <[email protected]>
Signed-off-by: ChrisJBurns <[email protected]>
ChrisJBurns
changed the title
Signed-off-by: ChrisJBurns <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2594 +/- ##
=======================================
Coverage 55.55% 55.55%
=======================================
Files 309 309
Lines 29129 29129
=======================================
Hits 16184 16184
Misses 11518 11518
Partials 1427 1427 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: ChrisJBurns <[email protected]>
Signed-off-by: ChrisJBurns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have mcpgroup e2e tests that only verify that certain conditions are set when CRDs are applied. These are perfect for integration tests as it doesn't need the full cluster setup and just a thin API server. This allows us to remove a e2e tests making builds and PR CI tests longer whilst also allowing us to catch failures earlier in the process. This PR makes the e2e tests 30-40 seconds faster.
As part of the PR we also make the status messages slightly nicer to read.