Add provenance and unsigned fields to the skills lock schema - #6015
Merged
Conversation
First PR of the Sigstore stack (RFC THV-0080 Stack 2, tracked in #5899): the lock file gains a typed provenance block recording the verified signer identity — the trust-on-first-use anchor later installs, syncs, and upgrades are checked against — and an unsigned flag recording an explicit --allow-unsigned trust decision. The two are mutually exclusive and validated with the same syntactic constraints as resolvedReference (graphic characters, bounded length), since the lock file is hand-editable and these values feed the identity policy future verifications enforce. The fields graduate from the Extra inline round-trip map into typed schema under version 1, exactly the path the forward-compat design reserved for them; that test's fixture moves to a still-unknown field. InstallOptions gains the AllowUnsigned option and the internal ProvenanceInfo/SigstoreBundle carriers the verification step (a later PR) will populate. No behavior changes yet — nothing produces or consumes these fields until the verifier lands.
JAORMX
approved these changes
Jul 27, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6015 +/- ##
==========================================
+ Coverage 72.10% 72.12% +0.01%
==========================================
Files 720 720
Lines 74745 74772 +27
==========================================
+ Hits 53898 53927 +29
+ Misses 16991 16985 -6
- Partials 3856 3860 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack 2: 1/8 · next: verifier wrapper (blocks on stacklok/toolhive-core#192)
provenance:block recording the verified signer identity — the trust-on-first-use anchor that later installs, syncs, and upgrades will be checked against — and anunsigned: trueflag recording an explicit--allow-unsignedtrust decision. The two are mutually exclusive.resolvedReference(graphic characters only, bounded length): the lock file is hand-editable and these values feed the identity policy future verifications enforce.Extrainline round-trip map into typed schema under version 1 — exactly the path the forward-compat design (from the Stack-1 review) reserved for them. A dedicated test proves old files carrying aprovenance:block parse into the typed field with no key duplication; the existing forward-compat test's fixture moves to a still-unknown field (attestations:).InstallOptionsgainsAllowUnsignedplus internalProvenanceInfo/SigstoreBundlecarriers that the verification step (a later PR in this stack) will populate.No behavior changes: nothing produces or consumes these fields until the verifier lands. The whole feature remains gated behind
TOOLHIVE_SKILLS_LOCK_ENABLED.Type of change
Test plan
Extraprovenance:block loads into the typed field, no duplicate keys on re-saveunsigned, required identity/issuer, control-character and length rejectiontask test+task lint-fixgreen; no swagger drift (API wiring comes with the verification PR)🤖 Generated with Claude Code