-
Notifications
You must be signed in to change notification settings - Fork 157
tests: split unit tests #15608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: split unit tests #15608
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @janisz - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Makefile
Outdated
| tee $(GO_TEST_OUTPUT_PATH) | ||
|
||
|
||
.PHONY: go-postgres-unit-tests | ||
go-postgres-unit-tests: go-postgres-unit-tests-central\ pkg\ migrator\ tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Default go-postgres-unit-tests dependencies are misconfigured
Escaped spaces combine all dependencies into one string, and the required prefixes are missing. Please list each dependency explicitly with the correct target names, as shown in the example.
Images are ready for the commit at 2aa4a74. To use with deploy scripts, first |
b9ad334
to
27789ec
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15608 +/- ##
==========================================
- Coverage 48.81% 48.81% -0.01%
==========================================
Files 2590 2590
Lines 190448 190471 +23
==========================================
+ Hits 92960 92969 +9
- Misses 90190 90206 +16
+ Partials 7298 7296 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
27789ec
to
16a66cc
Compare
Signed-off-by: Tomasz Janiszewski <[email protected]>
Signed-off-by: Tomasz Janiszewski <[email protected]>
53b20f0
to
0ab9ba4
Compare
/meow no |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/meow test |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Tomasz Janiszewski <[email protected]>
Signed-off-by: Tomasz Janiszewski <[email protected]>
Description
change me!
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!