Skip to content

tests: split unit tests #15608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

tests: split unit tests #15608

wants to merge 4 commits into from

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Jun 6, 2025

Description

change me!

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@janisz janisz marked this pull request as draft June 6, 2025 07:34
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @janisz - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Makefile Outdated
| tee $(GO_TEST_OUTPUT_PATH)


.PHONY: go-postgres-unit-tests
go-postgres-unit-tests: go-postgres-unit-tests-central\ pkg\ migrator\ tools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Default go-postgres-unit-tests dependencies are misconfigured

Escaped spaces combine all dependencies into one string, and the required prefixes are missing. Please list each dependency explicitly with the correct target names, as shown in the example.

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jun 6, 2025

Images are ready for the commit at 2aa4a74.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-26-g2aa4a74f47.

@janisz janisz force-pushed the run_unit_tests_in_parallel branch from b9ad334 to 27789ec Compare June 6, 2025 08:16
@janisz janisz changed the title run pg tests in parallel tests: run PG tests by package Jun 6, 2025
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 48.81%. Comparing base (362fd41) to head (27789ec).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
pkg/tlsutils/dial_context.go 0.00% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15608      +/-   ##
==========================================
- Coverage   48.81%   48.81%   -0.01%     
==========================================
  Files        2590     2590              
  Lines      190448   190471      +23     
==========================================
+ Hits        92960    92969       +9     
- Misses      90190    90206      +16     
+ Partials     7298     7296       -2     
Flag Coverage Δ
go-unit-tests 48.81% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@janisz janisz force-pushed the run_unit_tests_in_parallel branch from 27789ec to 16a66cc Compare June 6, 2025 12:27
@janisz janisz changed the title tests: run PG tests by package tests: split unit tests Jun 9, 2025
janisz added 2 commits June 9, 2025 16:52
Signed-off-by: Tomasz Janiszewski <[email protected]>
@janisz janisz force-pushed the run_unit_tests_in_parallel branch from 53b20f0 to 0ab9ba4 Compare June 9, 2025 14:52
@janisz
Copy link
Contributor Author

janisz commented Jun 10, 2025

/meow no

Copy link

openshift-ci bot commented Jun 10, 2025

@janisz: cat image

In response to this:

/meow no

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@janisz
Copy link
Contributor Author

janisz commented Jun 10, 2025

/meow test

Copy link

openshift-ci bot commented Jun 10, 2025

@janisz: cat image

In response to this:

/meow test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

janisz added 2 commits June 10, 2025 13:28
Signed-off-by: Tomasz Janiszewski <[email protected]>
Signed-off-by: Tomasz Janiszewski <[email protected]>
@janisz janisz closed this Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants