Add ExpressionStackDepthTooDeep and VaryExpressionStackDepthTooDeep to rejectable()

Signed-off-by: Jacinta Ferrant <[email protected]>

Author: jferrant

clarity-types/src/errors/ast.rs

@@ -114,7 +114,12 @@ impl ParseError {
     }
 
     pub fn rejectable(&self) -> bool {
-        matches!(*self.err, ParseErrors::InterpreterFailure)
+        matches!(
+            *self.err,
+            ParseErrors::InterpreterFailure
+                | ParseErrors::ExpressionStackDepthTooDeep
+                | ParseErrors::VaryExpressionStackDepthTooDeep
+        )
     }
 
     pub fn has_pre_expression(&self) -> bool {

stackslib/src/chainstate/stacks/db/transactions.rs

@@ -1288,19 +1288,6 @@ impl StacksChainState {
                                 ));
                             }
                             other_error => {
-                                // a [Vary]ExpressionDepthTooDeep error in this situation
-                                // invalidates the block, since this should have prevented the
-                                // block from getting relayed in the first place
-                                if let clarity_error::Parse(ref parse_error) = &other_error {
-                                    match *parse_error.err {
-                                        ParseErrors::ExpressionStackDepthTooDeep
-                                        | ParseErrors::VaryExpressionStackDepthTooDeep => {
-                                            info!("Transaction {} is problematic and should have prevented this block from being relayed", tx.txid());
-                                            return Err(Error::ClarityError(other_error));
-                                        }
-                                        _ => {}
-                                    }
-                                }
                                 if let clarity_error::Parse(err) = &other_error {
                                     if err.rejectable() {
                                         info!("Transaction {} is problematic and should have prevented this block from being relayed", tx.txid());