-
Notifications
You must be signed in to change notification settings - Fork 699
Added /v3/tenures/blocks/hash/{burnchain_block_hash} and /v3/tenures/blocks/hash/{burnchain_block_height} endpoints #6447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added /v3/tenures/blocks/hash/{burnchain_block_hash} and /v3/tenures/blocks/hash/{burnchain_block_height} endpoints #6447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good!
Just added some remarks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now there are CI issue that need to be addressed!
bcf0f4b
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6447 +/- ##
===========================================
+ Coverage 80.01% 80.15% +0.14%
===========================================
Files 558 562 +4
Lines 343239 343736 +497
===========================================
+ Hits 274634 275522 +888
+ Misses 68605 68214 -391
... and 64 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Description
Applicable issues
This patch adds two new endpoints /v3/tenures/blocks/hash/{burnchain_block_hash} and /v3/tenures/blocks/height/{burnchain_block_height} that allows querying by bitcoin hash and height.
Note: only Nakamoto tenures can be queried.
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml