Skip to content

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Sep 10, 2025

No description provided.

@obycode obycode requested review from a team as code owners September 10, 2025 15:05
@obycode obycode linked an issue Sep 10, 2025 that may be closed by this pull request
@obycode obycode changed the title feat: add Clarity4 keyword current-contract [Clarity-4] implement current-contract Sep 11, 2025
jferrant
jferrant previously approved these changes Sep 11, 2025
@obycode
Copy link
Contributor Author

obycode commented Sep 11, 2025

Resolved merge conflict in changelog.

@obycode obycode requested a review from jferrant September 12, 2025 15:13
jferrant
jferrant previously approved these changes Sep 12, 2025
@obycode obycode requested a review from fdefelici September 15, 2025 13:05
Copy link
Contributor

@fdefelici fdefelici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

Still merge conflict on changelog though

Jiloc
Jiloc previously approved these changes Sep 16, 2025
Copy link
Contributor

@Jiloc Jiloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@obycode obycode dismissed stale reviews from Jiloc and jferrant via 862e43c September 16, 2025 18:14
@obycode obycode added this pull request to the merge queue Sep 17, 2025
Merged via the queue into stacks-network:develop with commit 87c4373 Sep 17, 2025
296 of 300 checks passed
@obycode obycode deleted the feat/current-contract branch September 17, 2025 15:47
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 99.06542% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.55%. Comparing base (307d088) to head (6ea7ee9).
⚠️ Report is 34 commits behind head on develop.

Files with missing lines Patch % Lines
clarity/src/vm/analysis/type_checker/v2_05/mod.rs 0.00% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (78.55%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6450      +/-   ##
===========================================
- Coverage    79.95%   78.55%   -1.40%     
===========================================
  Files          563      563              
  Lines       345287   345511     +224     
===========================================
- Hits        276083   271433    -4650     
- Misses       69204    74078    +4874     
Files with missing lines Coverage Δ
clarity/src/vm/analysis/arithmetic_checker/mod.rs 92.48% <100.00%> (ø)
clarity/src/vm/analysis/type_checker/v2_1/mod.rs 90.32% <100.00%> (+<0.01%) ⬆️
clarity/src/vm/docs/mod.rs 90.24% <100.00%> (+0.01%) ⬆️
clarity/src/vm/tests/variables.rs 99.45% <100.00%> (+0.82%) ⬆️
clarity/src/vm/variables.rs 93.93% <100.00%> (+0.18%) ⬆️
clarity/src/vm/analysis/type_checker/v2_05/mod.rs 90.47% <0.00%> (ø)

... and 82 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 307d088...6ea7ee9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Clarity 4] current-contract
4 participants