Skip to content

[Clarity-4] Implement block-time #6478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

[Clarity-4] Implement block-time #6478

wants to merge 8 commits into from
+961 −89

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Sep 11, 2025

Description

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo

@obycode
feat: initial setup for block-time keyword
dda4af1
@obycode
feat: implement block-time
2b9e955 
This new keyword retrieves the timestamp for the current block by
storing it in the MARF. This means it also works as expected inside of
an `at-block` context.
@obycode obycode requested review from a team as code owners September 11, 2025 12:41
@obycode obycode moved this to Status: In Review in Stacks Core Eng Sep 11, 2025
@obycode obycode added this to the 3.3.0.0.0 milestone Sep 11, 2025
@obycode obycode linked an issue Sep 11, 2025 that may be closed by this pull request
[Clarity-4] block-time #6423
Open
@obycode
Copy link
Contributor Author

obycode commented Sep 11, 2025

Seems I still have some issues with the MARF in the unit tests. I'm taking a look.

jferrant
jferrant reviewed Sep 11, 2025
View reviewed changes
jferrant
jferrant reviewed Sep 11, 2025
View reviewed changes
@obycode
Copy link
Contributor Author

obycode commented Sep 11, 2025

Note to reviewers: I am definitely open to ideas for a better way to do this without passing the block time around so much.

@obycode
Copy link
Contributor Author

obycode commented Sep 11, 2025

Also, I'm realizing that I failed to epoch gate the setting of the timestamp in the MARF. That definitely needs to be fixed.

@obycode obycode marked this pull request as draft September 11, 2025 20:42
@obycode obycode marked this pull request as ready for review September 12, 2025 15:12
@obycode obycode requested a review from kantai September 12, 2025 15:15
@obycode
Copy link
Contributor Author

obycode commented Sep 12, 2025

Issues should be fixed and ready for review now.

jferrant
jferrant reviewed Sep 12, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jferrant jferrant jferrant left review comments

@kantai kantai Awaiting requested review from kantai

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Stacks Core Eng
Status: Status: In Review
Milestone
3.3.0.0.0
Development

Successfully merging this pull request may close these issues.

[Clarity-4] block-time
2 participants
@obycode @jferrant