Skip to content

Conversation

hstove
Copy link
Contributor

@hstove hstove commented Sep 12, 2025

This is a PR that cherry-picks the integration test from #6448 directly on top of develop. This allows us to verify that the resulting execution cost of the type of contract we're fixing in 6448 is consistent (ie not consensus breaking) with the change in that PR.

@hstove hstove requested review from a team as code owners September 12, 2025 15:56
@hstove hstove requested review from kantai and jferrant September 12, 2025 15:56
@hstove
Copy link
Contributor Author

hstove commented Sep 16, 2025

Closing since #6448 is merged

@hstove hstove closed this Sep 16, 2025
@hstove hstove deleted the fix/cost-error-undefined-var-compat branch September 16, 2025 13:34
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 0% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.25%. Comparing base (863429f) to head (daab158).
⚠️ Report is 75 commits behind head on develop.

Files with missing lines Patch % Lines
stacks-node/src/tests/signer/v0.rs 0.00% 64 Missing ⚠️
stackslib/src/chainstate/stacks/miner.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6487       +/-   ##
============================================
+ Coverage    65.71%   80.25%   +14.53%     
============================================
  Files          558      558               
  Lines       343277   343348       +71     
============================================
+ Hits        225575   275537    +49962     
+ Misses      117702    67811    -49891     
Files with missing lines Coverage Δ
stackslib/src/chainstate/stacks/miner.rs 80.36% <0.00%> (-0.59%) ⬇️
stacks-node/src/tests/signer/v0.rs 1.45% <0.00%> (-0.73%) ⬇️

... and 348 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 863429f...daab158. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant