Add vm_error field for transactions in Block Replay

[rdeioris]

Description

This patch improves the Block Replay endpoint by allowing it to returns the specific vm_error of a failed transaction.

A new test has been added and the TestRPC framework has been improved for allowing the addition of custom transactions in the tip block.

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

• Test coverage for new or modified code paths
• Changelog is updated
• Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
• New clarity functions have corresponding PR in clarity-benchmarking repo
• New integration test(s) added to bitcoin-tests.yml

[janniks]

Awesome! So we can assume any time there is a non-null vm-error string something went wrong, in my case we don't really care what went wrong, but can use the presence as a general failed indicator?

[rdeioris]

Awesome! So we can assume any time there is a non-null vm-error string something went wrong, in my case we don't really care what went wrong, but can use the presence as a general failed indicator?

Correct, the presence of vm_error signals a runtime error

[obycode]

LGTM!

[jcnelson]

I agree with @Jiloc that some documentation is needed. Once it's added then I'll approve. Thanks!

[obycode]

lgtm, just caught one typo

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ rdeioris
❌ rob-stacks
_{You have signed the CLA already but the status is still pending? Let us recheck it.}