Skip to content

Conversation

@Jiloc
Copy link
Contributor

@Jiloc Jiloc commented Oct 16, 2025

Description

The consensus tests currently take 20-30 seconds each to run on my machine, mostly due to the long cycle length of 100 blocks.
The new values are the lowest ones (empirically) accepted. Reducing the running of 4 consensus tests from ~1 min and 45 secs to ~2 seconds.

Only the MARF hashes currently changes from running the same tests. But I may be missing something given @jferrant comments in the code.

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo

@Jiloc Jiloc self-assigned this Oct 16, 2025
@Jiloc Jiloc added aac Avoiding Accidental Consensus aac-testing Avoiding Accidental Consensus Testing Specific Task labels Oct 16, 2025
@Jiloc Jiloc marked this pull request as ready for review October 16, 2025 13:40
@Jiloc Jiloc requested review from a team as code owners October 16, 2025 13:40
@jferrant
Copy link
Contributor

Nope I was debating lowering it myself in my WIP PR myself. I realized in the process that we actually lockup the stx for 12 reward cycles. So as long as we don't exceed that many reward cycles, we don't have to worry about restacking/reregistering signers.

jferrant
jferrant previously approved these changes Oct 16, 2025
@jacinta-stacks jacinta-stacks added this pull request to the merge queue Oct 27, 2025
Merged via the queue into stacks-network:develop with commit 02920d1 Oct 27, 2025
598 of 610 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aac Avoiding Accidental Consensus aac-testing Avoiding Accidental Consensus Testing Specific Task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants