-
Couldn't load subscription status.
- Fork 713
Chore/merge develop to aac client breaking #6618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: aac-client-breaking
Are you sure you want to change the base?
Chore/merge develop to aac client breaking #6618
Conversation
Add tests for `secp256k1-verify` and `secp256k1-recover?` while adding tests for this new function.
This removes the need for trying the recovery bytes to find the right one.
…eserialize` The signature will be checked after deserialization. Checking it here will cause a deserialization failure when what we actually want is a signature validation failure.
This check is unnecessary and it can't run in tests, since we sometimes provide fake signatures which will fail. Leaving it in place outside of tests to make sure we don't accidentally change some behavior.
Consensus in epoch 3.3 is broken because costs-4 changed.
…ove-clone-from-const chore: remove clone() from *_BLOCK_LIMIT_* constants
Suggestions from PR reviews.
…check feat: make `to-ascii?` result type tailored to the input
…n-check-order feat: enforce ordering of allowance check
… into chore/merge-develop-to-aac-client-breaking
Codecov Report❌ Patch coverage is ❌ Your project check has failed because the head coverage (72.60%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## aac-client-breaking #6618 +/- ##
=======================================================
- Coverage 76.85% 72.60% -4.25%
=======================================================
Files 571 572 +1
Lines 351879 351936 +57
=======================================================
- Hits 270445 255537 -14908
- Misses 81434 96399 +14965
... and 249 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't notice earlier, but the unit tests are failing
…on-timeout feat: add timeout in block validation endpoint
…h_3_3_0-in-node-config feat: allow epoch 3.3.0 in node config
Adding linux/arm64 to the arch list for manual docker builds
feat: add support for secp256r1 and replace libsecp256k1
… into chore/merge-develop-to-aac-client-breaking
Signed-off-by: Jacinta Ferrant <[email protected]>
No description provided.