Skip to content

Conversation

@jacinta-stacks
Copy link

No description provided.

obycode and others added 30 commits October 9, 2025 11:42
Add tests for `secp256k1-verify` and `secp256k1-recover?` while adding
tests for this new function.
This removes the need for trying the recovery bytes to find the right
one.
…eserialize`

The signature will be checked after deserialization. Checking it here
will cause a deserialization failure when what we actually want is a
signature validation failure.
This check is unnecessary and it can't run in tests, since we sometimes
provide fake signatures which will fail. Leaving it in place outside of
tests to make sure we don't accidentally change some behavior.
Consensus in epoch 3.3 is broken because costs-4 changed.
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 79.60526% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.60%. Comparing base (c215d2b) to head (d4d08b8).

Files with missing lines Patch % Lines
stacks-node/src/tests/neon_integrations.rs 11.53% 23 Missing ⚠️
.../analysis/type_checker/v2_1/natives/conversions.rs 90.90% 3 Missing ⚠️
stackslib/src/chainstate/stacks/db/transactions.rs 40.00% 3 Missing ⚠️
stackslib/src/clarity_cli.rs 50.00% 2 Missing ⚠️

❌ Your project check has failed because the head coverage (72.60%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           aac-client-breaking    #6618      +/-   ##
=======================================================
- Coverage                76.85%   72.60%   -4.25%     
=======================================================
  Files                      571      572       +1     
  Lines                   351879   351936      +57     
=======================================================
- Hits                    270445   255537   -14908     
- Misses                   81434    96399   +14965     
Files with missing lines Coverage Δ
clarity-types/src/errors/mod.rs 76.74% <ø> (ø)
clarity-types/src/types/signatures.rs 92.16% <100.00%> (-0.45%) ⬇️
...y/src/vm/analysis/type_checker/v2_1/natives/mod.rs 87.27% <100.00%> (-0.09%) ⬇️
...c/vm/analysis/type_checker/v2_1/tests/contracts.rs 89.84% <ø> (-5.91%) ⬇️
...vm/analysis/type_checker/v2_1/tests/conversions.rs 100.00% <100.00%> (ø)
...ity/src/vm/analysis/type_checker/v2_1/tests/mod.rs 83.92% <ø> (-15.93%) ⬇️
clarity/src/vm/functions/post_conditions.rs 88.88% <100.00%> (+2.77%) ⬆️
clarity/src/vm/tests/post_conditions.rs 89.16% <100.00%> (-10.84%) ⬇️
stacks-node/src/tests/nakamoto_integrations.rs 43.77% <ø> (-15.22%) ⬇️
stackslib/src/chainstate/coordinator/tests.rs 81.91% <100.00%> (-9.40%) ⬇️
... and 6 more

... and 249 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c215d2b...d4d08b8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@francesco-stacks francesco-stacks self-requested a review October 23, 2025 14:56
Copy link

@francesco-stacks francesco-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice earlier, but the unit tests are failing

@francesco-stacks francesco-stacks dismissed their stale review October 23, 2025 14:57

failing unit tests

brice-stacks and others added 5 commits October 23, 2025 15:44
…on-timeout

feat: add timeout in block validation endpoint
…h_3_3_0-in-node-config

feat: allow epoch 3.3.0 in node config
Adding linux/arm64 to the arch list for manual docker builds
feat: add support for secp256r1 and replace libsecp256k1
… into chore/merge-develop-to-aac-client-breaking
Signed-off-by: Jacinta Ferrant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants