fix(react-query): add query params to query key #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-casey
approved these changes
Jan 21, 2025
| @@ -122,7 +122,7 @@ describe("Generated API Client", () => { | |||
| it("can pass query params", async () => { | |||
| const { queryFn, queryKey } = client.cats.useList({ color: "black" }); | |||
|
|
|||
| expect(queryKey).toEqual(["/api/cats"]); | |||
| expect(queryKey).toEqual(["/api/cats?color=black"]); | |||
There was a problem hiding this comment.
I could picture the query key being an array to make invalidation easier to do piecemeal, but that would be when stl-api reaches a more mature state
Suggested change
| expect(queryKey).toEqual(["/api/cats?color=black"]); | |
| expect(queryKey).toEqual(["/api/cats", "color=black"]); |
There was a problem hiding this comment.
ideally our query keys would be hierarchical (see tkdoko's recs)
so that e.g. client.cats.getQueryKey() would be the key that invalidates everything under client.cats
but yes, that would be for later...
There was a problem hiding this comment.
we can probably split this array, at least
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the query key should contain all the dependencies of the query, so it should also include the query params