Best offset prefetcher#10
Conversation
hlitz
left a comment
hlitz
left a comment
There was a problem hiding this comment.
mostly nits. The only feature request I have is some stats and potentially some useful configuration parameters.
|
|
||
| // num run throughs to make before round over | ||
| const uint64_t RND_MAX = 100; | ||
| //const uint64_t RND_MAX = 50; |
There was a problem hiding this comment.
remove multiple constants. If you believe these should be configurable, add a new parameter that can be defined via the cfg file.
| error.c_str()); | ||
| return; | ||
| } | ||
| module_mapper_ = module_mapper_t::create(directory_.modfile_bytes, |
There was a problem hiding this comment.
hmm is this a current bug? If yes please extract it into a separate commit/pull request
| uint64_t current_round; | ||
| uint64_t test_offset_index; | ||
| uint64_t current_offset; | ||
| #ifndef TEST |
There was a problem hiding this comment.
remove and add some actual stats (look how the other prefetchers are doing it).
Can you think of other useful stats besides emitted prefetches? This is very helpful for quick debugging the out file if things do not perform like expected.
hlitz
left a comment
hlitz
left a comment
There was a problem hiding this comment.
Please merge with the prior commit, and do another pull request consisting of a single commit.
…ved is to add configurability to the prefetcher from the configuration files.
Cleaned up code a bit. Cleand up syntax of source files. Next step before pull request approved is to add configurability to the prefetcher from the configuration files. Fixed up code to standards. Added best offset prefetcher source files to forked branch.
2 participants
This branch contains the implementation of the best offset prefetcher.