Skip to content

Conversation

@akshatvishu
Copy link
Contributor

This PR adds a warning note to the CONTRIBUTING.md file.

The Problem:
The "Environment Setup" guide recommends using Python 3.11, but the .pre-commit-config.yaml file requires Python 3.10 . This causes pre-commit install to fail for new contributors who follow the instructions and only have Python 3.11 .

The Fix:
This note clarifies the discrepancy before the setup instructions. It advises contributors to either ensure python3.10 is also available on their PATH or simply use python=3.10 for their virtual environment to satisfy both requirements.

Hi @TomeHirata , I've pushed the requested changes. Thanks!

Copy link
Collaborator

@TomeHirata TomeHirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomeHirata TomeHirata merged commit fe03ead into stanfordnlp:main Nov 12, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants