Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional skylight requirement and allow 0 chance config #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Xalcon
Copy link

@Xalcon Xalcon commented Jul 2, 2022

Greetings! Thank you for this small but genious mod.

There are a lot of automation mods that will trip up when a hefty crop spawns. This PR adds 2 simple changes, both are done in a way that keep the original behavior as the default.

1. Allow 0 weight config for spawns

Previously, the weight was limited to a value between 1 and 100. I've extended the range to include 0 and added a check for 0 in the onCropGrow event handler. The default of 25 is unchanged. This option is targeted towards modpacks which only want to use the hefty crops as decorative objects. It would be up to them to add options to obtain the hefty crops when disabling the spawning.

2. Add sky light requirement

As requested in issue #2, I've added a configuration option that allows hefty crops to only spawn under direct sky light (sky light level == 15). This still allows crops to grow under glas since glas does not change the skylight level, but anything that reduces the skylight level for a given location, would prevent hefty crops to grow. The default value is set to false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant