Skip to content

first issue to initialize hint accountant#2372

Closed
Yael-Starkware wants to merge 1 commit intomainfrom
yael/first_issue_in_the_rep
Closed

first issue to initialize hint accountant#2372
Yael-Starkware wants to merge 1 commit intomainfrom
yael/first_issue_in_the_rep

Conversation

@Yael-Starkware
Copy link
Copy Markdown
Collaborator

@Yael-Starkware Yael-Starkware commented Mar 23, 2026

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

This change is Reviewable

@github-actions
Copy link
Copy Markdown

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     20.647 s ±  0.079 s    [User: 19.468 s, System: 1.177 s]
  Range (min … max):   20.592 s … 20.703 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     20.605 s ±  0.039 s    [User: 19.444 s, System: 1.158 s]
  Range (min … max):   20.577 s … 20.633 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     11.092 s ±  0.041 s    [User: 19.561 s, System: 1.155 s]
  Range (min … max):   11.063 s … 11.121 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     11.086 s ±  0.024 s    [User: 19.494 s, System: 1.192 s]
  Range (min … max):   11.069 s … 11.103 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.574 s ±  0.271 s    [User: 38.075 s, System: 1.248 s]
  Range (min … max):   10.383 s … 10.766 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.738 s ±  0.082 s    [User: 37.960 s, System: 1.263 s]
  Range (min … max):   10.680 s … 10.796 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.02 ± 0.03 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.589 s ±  0.095 s    [User: 38.349 s, System: 1.211 s]
  Range (min … max):   10.521 s … 10.656 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.385 s ±  0.023 s    [User: 38.461 s, System: 1.195 s]
  Range (min … max):   10.369 s … 10.401 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.02 ± 0.01 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.599 s ±  0.281 s    [User: 39.179 s, System: 1.130 s]
  Range (min … max):   10.400 s … 10.798 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.436 s ±  0.050 s    [User: 39.536 s, System: 1.127 s]
  Range (min … max):   10.400 s … 10.471 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.02 ± 0.03 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.652 s ±  0.094 s    [User: 39.261 s, System: 1.208 s]
  Range (min … max):   10.585 s … 10.718 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.527 s ±  0.058 s    [User: 39.552 s, System: 1.214 s]
  Range (min … max):   10.486 s … 10.569 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.01 ± 0.01 times faster than hyper_threading_main threads: 16


Copy link
Copy Markdown
Collaborator

@YairVaknin-starkware YairVaknin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@YairVaknin-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Yael-Starkware).

@github-actions
Copy link
Copy Markdown

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.120 ± 0.009 2.110 2.136 1.00
head big_factorial 2.128 ± 0.020 2.108 2.171 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.064 ± 0.014 2.051 2.098 1.00
head big_fibonacci 2.065 ± 0.018 2.048 2.110 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.410 ± 0.019 7.382 7.439 1.00
head blake2s_integration_benchmark 7.432 ± 0.057 7.373 7.578 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.197 ± 0.012 2.181 2.223 1.01 ± 0.01
head compare_arrays_200000 2.180 ± 0.013 2.162 2.199 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.444 ± 0.012 1.430 1.465 1.00 ± 0.01
head dict_integration_benchmark 1.443 ± 0.009 1.431 1.460 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.228 ± 0.006 1.222 1.242 1.00
head field_arithmetic_get_square_benchmark 1.239 ± 0.007 1.231 1.252 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.488 ± 0.015 7.466 7.516 1.00
head integration_builtins 7.527 ± 0.023 7.499 7.566 1.01 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.599 ± 0.069 7.554 7.789 1.00
head keccak_integration_benchmark 7.611 ± 0.027 7.567 7.650 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.207 ± 0.028 2.177 2.253 1.01 ± 0.01
head linear_search 2.177 ± 0.014 2.162 2.207 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.498 ± 0.006 1.492 1.509 1.00
head math_cmp_and_pow_integration_benchmark 1.511 ± 0.005 1.504 1.519 1.01 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.462 ± 0.008 1.454 1.481 1.00
head math_integration_benchmark 1.478 ± 0.011 1.463 1.499 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.217 ± 0.005 1.210 1.226 1.00
head memory_integration_benchmark 1.226 ± 0.025 1.210 1.292 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.538 ± 0.014 1.528 1.576 1.00
head operations_with_data_structures_benchmarks 1.549 ± 0.005 1.543 1.562 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 531.3 ± 1.0 528.9 532.5 1.00
head pedersen 531.7 ± 1.3 530.2 534.5 1.00 ± 0.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 620.4 ± 14.6 612.0 661.1 1.00 ± 0.03
head poseidon_integration_benchmark 617.8 ± 6.1 612.5 633.3 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.824 ± 0.012 1.807 1.846 1.00
head secp_integration_benchmark 1.838 ± 0.040 1.821 1.952 1.01 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 637.9 ± 6.5 630.3 648.9 1.00 ± 0.01
head set_integration_benchmark 635.8 ± 4.5 632.6 648.5 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.219 ± 0.015 4.193 4.237 1.00
head uint256_integration_benchmark 4.263 ± 0.009 4.246 4.275 1.01 ± 0.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants