Skip to content

adding code cov workflow file to workflows list#2373

Merged
sobhe-Starkware merged 1 commit intomainfrom
add-code-cov
Mar 25, 2026
Merged

adding code cov workflow file to workflows list#2373
sobhe-Starkware merged 1 commit intomainfrom
add-code-cov

Conversation

@sobhe-Starkware
Copy link
Copy Markdown
Contributor

@sobhe-Starkware sobhe-Starkware commented Mar 24, 2026

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

This change is Reviewable

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 24, 2026

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     25.036 s ±  0.047 s    [User: 24.583 s, System: 0.448 s]
  Range (min … max):   25.003 s … 25.069 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     25.035 s ±  0.112 s    [User: 24.588 s, System: 0.442 s]
  Range (min … max):   24.956 s … 25.114 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     13.456 s ±  0.007 s    [User: 24.630 s, System: 0.459 s]
  Range (min … max):   13.451 s … 13.462 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     13.401 s ±  0.036 s    [User: 24.573 s, System: 0.424 s]
  Range (min … max):   13.376 s … 13.426 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.042 s ±  0.295 s    [User: 35.568 s, System: 0.600 s]
  Range (min … max):    9.834 s … 10.251 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.064 s ±  0.009 s    [User: 35.787 s, System: 0.607 s]
  Range (min … max):   10.058 s … 10.071 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.00 ± 0.03 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):      9.808 s ±  0.448 s    [User: 36.359 s, System: 0.619 s]
  Range (min … max):    9.491 s … 10.124 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):      9.636 s ±  0.085 s    [User: 36.561 s, System: 0.619 s]
  Range (min … max):    9.576 s …  9.696 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.02 ± 0.05 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):      9.912 s ±  0.188 s    [User: 36.632 s, System: 0.643 s]
  Range (min … max):    9.779 s … 10.046 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):      9.676 s ±  0.011 s    [User: 36.505 s, System: 0.639 s]
  Range (min … max):    9.668 s …  9.683 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.02 ± 0.02 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):      9.661 s ±  0.056 s    [User: 36.566 s, System: 0.705 s]
  Range (min … max):    9.621 s …  9.700 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):      9.912 s ±  0.040 s    [User: 36.656 s, System: 0.708 s]
  Range (min … max):    9.883 s …  9.940 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.03 ± 0.01 times faster than hyper_threading_pr threads: 16


@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 24, 2026

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.135 ± 0.023 2.114 2.174 1.01 ± 0.01
head big_factorial 2.120 ± 0.008 2.112 2.135 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.064 ± 0.009 2.051 2.081 1.00 ± 0.01
head big_fibonacci 2.063 ± 0.016 2.048 2.097 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.450 ± 0.081 7.385 7.640 1.00
head blake2s_integration_benchmark 7.526 ± 0.095 7.397 7.641 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.188 ± 0.011 2.172 2.207 1.00
head compare_arrays_200000 2.207 ± 0.026 2.185 2.268 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.428 ± 0.015 1.414 1.467 1.00 ± 0.01
head dict_integration_benchmark 1.423 ± 0.008 1.414 1.438 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.224 ± 0.005 1.217 1.232 1.00
head field_arithmetic_get_square_benchmark 1.232 ± 0.010 1.223 1.249 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.493 ± 0.013 7.474 7.512 1.00
head integration_builtins 7.534 ± 0.048 7.479 7.654 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.610 ± 0.060 7.518 7.754 1.00 ± 0.01
head keccak_integration_benchmark 7.598 ± 0.062 7.514 7.751 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.172 ± 0.011 2.158 2.185 1.00
head linear_search 2.175 ± 0.028 2.154 2.245 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.496 ± 0.005 1.488 1.506 1.00
head math_cmp_and_pow_integration_benchmark 1.502 ± 0.017 1.489 1.547 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.457 ± 0.009 1.447 1.474 1.00
head math_integration_benchmark 1.463 ± 0.004 1.456 1.469 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.236 ± 0.011 1.220 1.257 1.00
head memory_integration_benchmark 1.244 ± 0.019 1.235 1.297 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.569 ± 0.011 1.558 1.595 1.00 ± 0.01
head operations_with_data_structures_benchmarks 1.565 ± 0.006 1.556 1.574 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 535.6 ± 1.8 533.9 539.1 1.00
head pedersen 537.8 ± 3.4 535.0 546.4 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 624.8 ± 3.5 622.2 632.7 1.00
head poseidon_integration_benchmark 627.9 ± 2.5 625.1 632.5 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.853 ± 0.021 1.839 1.905 1.01 ± 0.01
head secp_integration_benchmark 1.836 ± 0.010 1.827 1.862 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 639.7 ± 3.0 635.9 646.7 1.00
head set_integration_benchmark 641.0 ± 6.0 636.8 656.8 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.269 ± 0.013 4.250 4.287 1.00
head uint256_integration_benchmark 4.269 ± 0.027 4.242 4.324 1.00 ± 0.01

Copy link
Copy Markdown
Collaborator

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yael-Starkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on sobhe-Starkware).


.github/.codecov.yml line 1 at r1 (raw file):

# .codecov.yml

There is already a .github/codecov.yml file in the repo.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Copy Markdown
Collaborator

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yael-Starkware reviewed 3 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sobhe-Starkware).


-- commits line 1 at r2:
looks like you have along list of commits here.

Copy link
Copy Markdown
Collaborator

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yael-Starkware made 1 comment and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sobhe-Starkware).

Copy link
Copy Markdown
Collaborator

@phil-starkware phil-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@phil-starkware reviewed 3 files and made 1 comment.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on sobhe-Starkware).

@sobhe-Starkware sobhe-Starkware added this pull request to the merge queue Mar 25, 2026
Merged via the queue into main with commit cf6a26b Mar 25, 2026
66 of 67 checks passed
@sobhe-Starkware sobhe-Starkware deleted the add-code-cov branch March 25, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants