feat: add test_helpers module (error_utils, test_utils) behind function_runner flag#2378
Open
naor-starkware wants to merge 7 commits intonaor/refactor/rename-feature-flagfrom
Open
feat: add test_helpers module (error_utils, test_utils) behind function_runner flag#2378naor-starkware wants to merge 7 commits intonaor/refactor/rename-feature-flagfrom
naor-starkware wants to merge 7 commits intonaor/refactor/rename-feature-flagfrom
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## naor/refactor/rename-feature-flag #2378 +/- ##
=====================================================================
- Coverage 96.07% 96.06% -0.01%
=====================================================================
Files 105 107 +2
Lines 37737 37968 +231
=====================================================================
+ Hits 36254 36475 +221
- Misses 1483 1493 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Benchmark Results for unmodified programs 🚀
|
…on_runner flag - Create vm/src/test_helpers/ with error_utils.rs and test_utils.rs - Move from cairo_test_suite/ (fix filename typo: utlis → utils) - Fix crate:: import paths (were cairo_vm:: when outside the crate) - Fix $crate in macro_export macro (clippy::crate_in_macro_def) - Simplify load_cairo_program! path using with_file_name() - Gate module behind function_runner feature in lib.rs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ram! and error_utils checkers Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add AlwaysFailConversion helper + 2 tests for assert_mr_eq! unwrap_or_else panic branch (no-message and message variants) - Allow clippy::result_large_err on hint_err test helper Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
naor-starkware
force-pushed
the
naor/feat/add_test_helpers
branch
from
6ec5328 to
ce3aeb1
Compare
… noise Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…y function name error #[macro_export] macros containing closures (|x| ...) cause llvm-cov to emit a "function name is empty" error. Replaced unwrap_or_else(|e| panic!(...)) with match expressions to eliminate closures from macro expansions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
OmriEshhar1
approved these changes
Mar 31, 2026
Collaborator
OmriEshhar1
left a comment
OmriEshhar1
left a comment
There was a problem hiding this comment.
@OmriEshhar1 reviewed 7 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on naor-starkware).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TITLE
Description
Description of the pull request changes and motivation.
Checklist
This change is