Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix starknet-sierra-upgrade-validate/src/main.rs warning #7479

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

goofylfg
Copy link

use of deprecated method clap::Arg::requires_all: Replaced with Arg::requires_ifs

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion


crates/bin/starknet-sierra-upgrade-validate/src/main.rs line 55 at r1 (raw file):

    #[arg(
        long,
        requires_ifs = [("fullnode_args", "true")],

what does that mean now?
fullnode_args is a set of arguments.

Code quote:

        long,
        requires_ifs = [("fullnode_args", "true")],

@goofylfg
Copy link
Author

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion

crates/bin/starknet-sierra-upgrade-validate/src/main.rs line 55 at r1 (raw file):

    #[arg(
        long,
        requires_ifs = [("fullnode_args", "true")],

what does that mean now? fullnode_args is a set of arguments.

Code quote:

        long,
        requires_ifs = [("fullnode_args", "true")],

ref from this:https://rust.libhunt.com/clap-rs-changelog/4.0.0

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion


crates/bin/starknet-sierra-upgrade-validate/src/main.rs line 55 at r1 (raw file):

    #[arg(
        long,
        requires_ifs = [("fullnode_args", "true")],

this is the same as IsPresent?

Code quote:

", "true")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants