Open
Conversation
dan-starkware
force-pushed
the
dan/chain_id
branch
2 times, most recently
from
f28b70b to
9aa09e3
Compare
dan-starkware
force-pushed
the
dan/chain_id
branch
from
9aa09e3 to
154cf21
Compare
yoavGrs
approved these changes
Sep 10, 2023
Contributor
yoavGrs
left a comment
yoavGrs
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)
ShahakShama
approved these changes
Sep 12, 2023
Contributor
ShahakShama
left a comment
ShahakShama
left a comment
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is