Add transaction_index to getTransactionReceipt and getEvents#327
Open
cchudant wants to merge 3 commits intostarkware-libs:release/v0.10.1-rc.0from
Open
Add transaction_index to getTransactionReceipt and getEvents#327cchudant wants to merge 3 commits intostarkware-libs:release/v0.10.1-rc.0from
cchudant wants to merge 3 commits intostarkware-libs:release/v0.10.1-rc.0from
Conversation
eitanm-starkware
changed the base branch from
release/v0.9.0-rc.3
to
release/v0.10.1-rc.0
Contributor
|
Can we make this non-breaking(ie add flag to receive index)? Also, it would be good to not have code duplication. Can create a component for TRANSACTION_INDEX(see BLOCK_NUMBER for example). Is this pr useful independently of the prs you referenced above? @cchudant |
eitanm-starkware
force-pushed
the
release/v0.10.1-rc.0
branch
from
a4e4012 to
1fe99ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This was proposed by @kkovaacs, but I added the field to getTransactionReceipt too instead of just getEvents.
Related to #326 (which adds finality_status to the same types) and #325 (which fixed block_number in the same types)
Affects #323
Checklist:
npm run validate_allnpm run format(i'm using the github interface for these spec PRs, should I really clone the repo on my machine to test it there and check this checklist?)