add program_segment to ProverInput and extract program_segment in the adapter#1640
Draft
ohad-nir-starkware wants to merge 1 commit intomainfrom
Draft
add program_segment to ProverInput and extract program_segment in the adapter#1640ohad-nir-starkware wants to merge 1 commit intomainfrom
ohad-nir-starkware wants to merge 1 commit intomainfrom
Conversation
f1bb63b to
eaec085
Compare
anatgstarkware
requested changes
Feb 15, 2026
Contributor
anatgstarkware
left a comment
There was a problem hiding this comment.
@anatgstarkware made 1 comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @ohad-nir-starkware and @Stavbe).
stwo_cairo_prover/crates/adapter/src/adapter.rs line 64 at r1 (raw file):
} fn extract_int_segment(segment: &[Option<MaybeRelocatable>]) -> Vec<[u32; 8]> {
Is this how they extract the program segment in the vm? looks very weird to assume that it's all the ints in memory
Code quote:
extract_int_segment
Contributor
|
Previously, anatgstarkware (anatg) wrote…
As you told me f2f, this code is taken not from the VM, but from another place in the adapter - please remove duplications |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is