Skip to content

add program_segment to ProverInput and extract program_segment in the adapter#1640

Draft
ohad-nir-starkware wants to merge 1 commit intomainfrom
ohadn/adapter-output-program_segment
Draft

add program_segment to ProverInput and extract program_segment in the adapter#1640
ohad-nir-starkware wants to merge 1 commit intomainfrom
ohadn/adapter-output-program_segment

Conversation

@ohad-nir-starkware
Copy link
Collaborator

@ohad-nir-starkware ohad-nir-starkware commented Feb 11, 2026

This change is Reviewable

@ohad-nir-starkware ohad-nir-starkware force-pushed the ohadn/adapter-output-program_segment branch from f1bb63b to eaec085 Compare February 11, 2026 16:36
Copy link
Contributor

@anatgstarkware anatgstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anatgstarkware made 1 comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @ohad-nir-starkware and @Stavbe).


stwo_cairo_prover/crates/adapter/src/adapter.rs line 64 at r1 (raw file):

}

fn extract_int_segment(segment: &[Option<MaybeRelocatable>]) -> Vec<[u32; 8]> {

Is this how they extract the program segment in the vm? looks very weird to assume that it's all the ints in memory

Code quote:

extract_int_segment

@anatgstarkware
Copy link
Contributor

stwo_cairo_prover/crates/adapter/src/adapter.rs line 64 at r1 (raw file):

Previously, anatgstarkware (anatg) wrote…

Is this how they extract the program segment in the vm? looks very weird to assume that it's all the ints in memory

As you told me f2f, this code is taken not from the VM, but from another place in the adapter - please remove duplications

@ohad-nir-starkware ohad-nir-starkware marked this pull request as draft March 4, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants