Conversation
4649712 to
0300067
Compare
az-starkware
left a comment
There was a problem hiding this comment.
@az-starkware reviewed 40 files and all commit messages, and made 2 comments.
Reviewable status: 40 of 96 files reviewed, 2 unresolved discussions (waiting on anatgstarkware and gilbens-starkware).
stwo_cairo_prover/crates/dev_utils/src/vm_utils.rs line 30 at r2 (raw file):
program_path: &PathBuf, program_type: ProgramType, no_ecop: bool,
Suggestion:
layout: LayoutName,stwo_cairo_prover/crates/prover/src/witness/builtins.rs line 135 at r2 (raw file):
id: "pedersen_points_small_0".to_owned(), }) { panic!("Not supporting ec_op_builtin with canonical_small preprocessed trace.")
Why? What is missing to support it?
0300067 to
66e791a
Compare
anatgstarkware
left a comment
There was a problem hiding this comment.
@anatgstarkware made 2 comments.
Reviewable status: 33 of 104 files reviewed, 2 unresolved discussions (waiting on az-starkware and gilbens-starkware).
stwo_cairo_prover/crates/prover/src/witness/builtins.rs line 135 at r2 (raw file):
Previously, az-starkware wrote…
Why? What is missing to support it?
Fixed as we said f2f
stwo_cairo_prover/crates/dev_utils/src/vm_utils.rs line 30 at r2 (raw file):
program_path: &PathBuf, program_type: ProgramType, no_ecop: bool,
Done.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
az-starkware
left a comment
There was a problem hiding this comment.
@az-starkware reviewed 71 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on anatgstarkware and gilbens-starkware).
b6532f1 to
d0dd16f
Compare
|
Don't you have two sources of truth here? Code quote: columns: Vec<Box<dyn PreProcessedColumn>>,
variant: PreProcessedTraceVariant, |
|
Previously, ilyalesokhin-starkware wrote…
can you remove the |
d0dd16f to
dd833a6
Compare

Note
Medium Risk
Adds a new Cairo builtin (
ec_op) into the proving pipeline and updates VM layout handling, which can affect trace generation, constraint evaluation, and proof compatibility. While changes are mostly additive, they touch core prover/claim wiring and builtins relocation/padding logic.Overview
Adds full prover support for the Cairo
ec_opbuiltin. The adapter now relocates/records anec_opsegment, builtins padding/counting includes it, and the prover wires newec_op_builtinandpartial_ec_mul_genericclaims/components through claim generation, interaction-claim aggregation, component lists, and debug tooling.Updates execution/config plumbing.
run_and_adaptnow accepts aLayoutNameand callers default toLayoutName::all_cairo_stwo(with tests adjusted), the preprocessed-tracePreProcessedTraceVarianttype is moved tostwo_cairo_commonand carried onPreProcessedTrace, and test data is updated to exerciseec_opusage. Separately removes unusedmix_into/is_emptyhelpers and tweaksPackedPartialEcMulGeneric::deduce_outputto return a boxed packed result.Written by Cursor Bugbot for commit dd833a6. This will update automatically on new commits. Configure here.
This change is