Conversation
idan-starkware
force-pushed
the
idan/main/breaking-ci-to-workflows
branch
from
4a9f8db to
8ea00d2
Compare
idan-starkware
force-pushed
the
idan/main/namespace-cache
branch
from
d18383e to
ad8693f
Compare
idan-starkware
force-pushed
the
idan/main/breaking-ci-to-workflows
branch
2 times, most recently
from
7de8098 to
b9d684c
Compare
idan-starkware
changed the title
idan-starkware
changed the base branch from
idan/main/namespace-cache
to
graphite-base/1706
idan-starkware
force-pushed
the
graphite-base/1706
branch
from
ad8693f to
18df1fc
Compare
idan-starkware
force-pushed
the
idan/main/breaking-ci-to-workflows
branch
from
e8a10a9 to
ab58d30
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| types: | ||
| - opened | ||
| - reopened | ||
| - edited |
There was a problem hiding this comment.
PR edited type cancels in-progress heavy CI runs
Medium Severity
Adding edited to pull_request.types across all workflows, combined with cancel-in-progress: true, means editing a PR title or description will cancel and restart all currently running CI jobs for that PR. The old workflow defaulted to opened, synchronize, reopened (no edited). For long-running test jobs on xlarge runners like cairo-prover-tests and scarb-test, a simple typo fix in the PR description could cancel nearly-complete test runs, wasting significant CI resources and developer time.
Additional Locations (1)
| - run: scarb test --features=${{ matrix.feature }} --package ${{ matrix.package }} | ||
| - if: matrix.package == 'stwo_cairo_verifier' | ||
| run: scarb --profile proving execute --package stwo_cairo_verifier --features ${{ matrix.feature }} --print-resource-usage --output none --arguments-file ${{ matrix.proof_file }} | ||
|
|
There was a problem hiding this comment.
Inconsistent Scarb setup action usage in scarb-test.yaml
Low Severity
The scarb-test job uses software-mansion/setup-scarb@v1 directly with a hardcoded version "2.15.0", while all other workflows (cairo-prover-tests, code-quality, nightly) use the new setup-repo-scarb composite action that centralizes the default version. This duplicates the version string and means a future version bump needs to be applied in two places — the wrapper action and this file — risking drift.
1 participant
This change is