Ohadn/remove program segment from proof#1707
Open
ohad-nir-starkware wants to merge 1 commit intoohadn/verify_program_builtin-deploymentfrom
Open
Ohadn/remove program segment from proof#1707ohad-nir-starkware wants to merge 1 commit intoohadn/verify_program_builtin-deploymentfrom
ohad-nir-starkware wants to merge 1 commit intoohadn/verify_program_builtin-deploymentfrom
Conversation
4c615f8 to
81411bc
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
7f380e3 to
80fe5b5
Compare
80fe5b5 to
17b718b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Changes the proof’s public-memory layout and transcript mixing by making the
programsection optional, which can affect proof compatibility and verification if producers/consumers get out of sync. Logic is straightforward but touches prover/verifier hashing and claim validation paths.Overview
This PR makes the
programmemory section inPublicMemoryoptional so proofs can omit the program segment when it is already included in the preprocessed trace (program_in_ppt).Prover and verifier logic is updated to conditionally include/mix/verify program data: packing public claims and Merkle mixing skip program IDs/values when absent,
verify_programis only run when provided, andget_verification_outputreturns a zero program hash when the program is omitted.Test utilities, constraint assertions, and golden proof fixtures are updated to pass the new
program_in_pptflag and reflect the updated serialized proof output.Written by Cursor Bugbot for commit 17b718b. This will update automatically on new commits. Configure here.
This change is