Skip to content

Ohadn/remove program segment from proof#1707

Open
ohad-nir-starkware wants to merge 1 commit intoohadn/verify_program_builtin-deploymentfrom
ohadn/remove_program_segment_from_proof
Open

Ohadn/remove program segment from proof#1707
ohad-nir-starkware wants to merge 1 commit intoohadn/verify_program_builtin-deploymentfrom
ohadn/remove_program_segment_from_proof

Conversation

@ohad-nir-starkware
Copy link
Collaborator

@ohad-nir-starkware ohad-nir-starkware commented Mar 22, 2026

Note

Medium Risk
Changes the proof’s public-memory layout and transcript mixing by making the program section optional, which can affect proof compatibility and verification if producers/consumers get out of sync. Logic is straightforward but touches prover/verifier hashing and claim validation paths.

Overview
This PR makes the program memory section in PublicMemory optional so proofs can omit the program segment when it is already included in the preprocessed trace (program_in_ppt).

Prover and verifier logic is updated to conditionally include/mix/verify program data: packing public claims and Merkle mixing skip program IDs/values when absent, verify_program is only run when provided, and get_verification_output returns a zero program hash when the program is omitted.

Test utilities, constraint assertions, and golden proof fixtures are updated to pass the new program_in_ppt flag and reflect the updated serialized proof output.

Written by Cursor Bugbot for commit 17b718b. This will update automatically on new commits. Configure here.


This change is Reviewable

@ohad-nir-starkware ohad-nir-starkware self-assigned this Mar 22, 2026
@ohad-nir-starkware ohad-nir-starkware force-pushed the ohadn/remove_program_segment_from_proof branch from 4c615f8 to 81411bc Compare March 22, 2026 20:28
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@ohad-nir-starkware ohad-nir-starkware force-pushed the ohadn/remove_program_segment_from_proof branch 9 times, most recently from 7f380e3 to 80fe5b5 Compare March 23, 2026 14:31
@ohad-nir-starkware ohad-nir-starkware force-pushed the ohadn/remove_program_segment_from_proof branch from 80fe5b5 to 17b718b Compare March 23, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant