-
Notifications
You must be signed in to change notification settings - Fork 62
pad the ppt program columns to allow lengths that arent powers of 2 #1712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ohad-nir-starkware
wants to merge
1
commit into
ohadn/remove_program_segment_from_proof
Choose a base branch
from
ohadn/padded-verify_program-simpler
base: ohadn/remove_program_segment_from_proof
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
241 changes: 241 additions & 0 deletions
241
stwo_cairo_prover/crates/cairo-air/src/components/subroutines/mem_verify_cond.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,241 @@ | ||
| // This file was created by the AIR team. | ||
|
|
||
| use crate::components::prelude::*; | ||
| use crate::components::subroutines::read_positive_num_bits_252::ReadPositiveNumBits252; | ||
|
|
||
| #[derive(Copy, Clone, Serialize, Deserialize, CairoSerialize)] | ||
| pub struct MemVerifyCond {} | ||
|
|
||
| impl MemVerifyCond { | ||
| #[allow(unused_parens)] | ||
| #[allow(clippy::double_parens)] | ||
| #[allow(non_snake_case)] | ||
| #[allow(clippy::unused_unit)] | ||
| #[allow(unused_variables)] | ||
| #[allow(clippy::too_many_arguments)] | ||
| pub fn evaluate<E: EvalAtRow>( | ||
| [mem_verify_cond_input_address, mem_verify_cond_input_value_limb_0, mem_verify_cond_input_value_limb_1, mem_verify_cond_input_value_limb_2, mem_verify_cond_input_value_limb_3, mem_verify_cond_input_value_limb_4, mem_verify_cond_input_value_limb_5, mem_verify_cond_input_value_limb_6, mem_verify_cond_input_value_limb_7, mem_verify_cond_input_value_limb_8, mem_verify_cond_input_value_limb_9, mem_verify_cond_input_value_limb_10, mem_verify_cond_input_value_limb_11, mem_verify_cond_input_value_limb_12, mem_verify_cond_input_value_limb_13, mem_verify_cond_input_value_limb_14, mem_verify_cond_input_value_limb_15, mem_verify_cond_input_value_limb_16, mem_verify_cond_input_value_limb_17, mem_verify_cond_input_value_limb_18, mem_verify_cond_input_value_limb_19, mem_verify_cond_input_value_limb_20, mem_verify_cond_input_value_limb_21, mem_verify_cond_input_value_limb_22, mem_verify_cond_input_value_limb_23, mem_verify_cond_input_value_limb_24, mem_verify_cond_input_value_limb_25, mem_verify_cond_input_value_limb_26, mem_verify_cond_input_value_limb_27, mem_verify_cond_input_cond]: [E::F; 30], | ||
| cond_address_col0: E::F, | ||
| cond_address_id_col1: E::F, | ||
| cond_address_limb_0_col2: E::F, | ||
| cond_address_limb_1_col3: E::F, | ||
| cond_address_limb_2_col4: E::F, | ||
| cond_address_limb_3_col5: E::F, | ||
| cond_address_limb_4_col6: E::F, | ||
| cond_address_limb_5_col7: E::F, | ||
| cond_address_limb_6_col8: E::F, | ||
| cond_address_limb_7_col9: E::F, | ||
| cond_address_limb_8_col10: E::F, | ||
| cond_address_limb_9_col11: E::F, | ||
| cond_address_limb_10_col12: E::F, | ||
| cond_address_limb_11_col13: E::F, | ||
| cond_address_limb_12_col14: E::F, | ||
| cond_address_limb_13_col15: E::F, | ||
| cond_address_limb_14_col16: E::F, | ||
| cond_address_limb_15_col17: E::F, | ||
| cond_address_limb_16_col18: E::F, | ||
| cond_address_limb_17_col19: E::F, | ||
| cond_address_limb_18_col20: E::F, | ||
| cond_address_limb_19_col21: E::F, | ||
| cond_address_limb_20_col22: E::F, | ||
| cond_address_limb_21_col23: E::F, | ||
| cond_address_limb_22_col24: E::F, | ||
| cond_address_limb_23_col25: E::F, | ||
| cond_address_limb_24_col26: E::F, | ||
| cond_address_limb_25_col27: E::F, | ||
| cond_address_limb_26_col28: E::F, | ||
| cond_address_limb_27_col29: E::F, | ||
| common_lookup_elements: &relations::CommonLookupElements, | ||
| eval: &mut E, | ||
| ) -> [E::F; 0] { | ||
| let M31_1 = E::F::from(M31::from(1)); | ||
|
|
||
| // cond=0 or cond=1.. | ||
| eval.add_constraint( | ||
| (mem_verify_cond_input_cond.clone() | ||
| * (M31_1.clone() - mem_verify_cond_input_cond.clone())), | ||
| ); | ||
| // cond_address. | ||
| eval.add_constraint( | ||
| (cond_address_col0.clone() | ||
| - (((mem_verify_cond_input_address.clone() - M31_1.clone()) | ||
| * mem_verify_cond_input_cond.clone()) | ||
| + M31_1.clone())), | ||
| ); | ||
| ReadPositiveNumBits252::evaluate( | ||
| [cond_address_col0.clone()], | ||
| cond_address_id_col1.clone(), | ||
| cond_address_limb_0_col2.clone(), | ||
| cond_address_limb_1_col3.clone(), | ||
| cond_address_limb_2_col4.clone(), | ||
| cond_address_limb_3_col5.clone(), | ||
| cond_address_limb_4_col6.clone(), | ||
| cond_address_limb_5_col7.clone(), | ||
| cond_address_limb_6_col8.clone(), | ||
| cond_address_limb_7_col9.clone(), | ||
| cond_address_limb_8_col10.clone(), | ||
| cond_address_limb_9_col11.clone(), | ||
| cond_address_limb_10_col12.clone(), | ||
| cond_address_limb_11_col13.clone(), | ||
| cond_address_limb_12_col14.clone(), | ||
| cond_address_limb_13_col15.clone(), | ||
| cond_address_limb_14_col16.clone(), | ||
| cond_address_limb_15_col17.clone(), | ||
| cond_address_limb_16_col18.clone(), | ||
| cond_address_limb_17_col19.clone(), | ||
| cond_address_limb_18_col20.clone(), | ||
| cond_address_limb_19_col21.clone(), | ||
| cond_address_limb_20_col22.clone(), | ||
| cond_address_limb_21_col23.clone(), | ||
| cond_address_limb_22_col24.clone(), | ||
| cond_address_limb_23_col25.clone(), | ||
| cond_address_limb_24_col26.clone(), | ||
| cond_address_limb_25_col27.clone(), | ||
| cond_address_limb_26_col28.clone(), | ||
| cond_address_limb_27_col29.clone(), | ||
| common_lookup_elements, | ||
| eval, | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_0_col2.clone() - mem_verify_cond_input_value_limb_0.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_1_col3.clone() - mem_verify_cond_input_value_limb_1.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_2_col4.clone() - mem_verify_cond_input_value_limb_2.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_3_col5.clone() - mem_verify_cond_input_value_limb_3.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_4_col6.clone() - mem_verify_cond_input_value_limb_4.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_5_col7.clone() - mem_verify_cond_input_value_limb_5.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_6_col8.clone() - mem_verify_cond_input_value_limb_6.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_7_col9.clone() - mem_verify_cond_input_value_limb_7.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_8_col10.clone() - mem_verify_cond_input_value_limb_8.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_9_col11.clone() - mem_verify_cond_input_value_limb_9.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_10_col12.clone() - mem_verify_cond_input_value_limb_10.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_11_col13.clone() - mem_verify_cond_input_value_limb_11.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_12_col14.clone() - mem_verify_cond_input_value_limb_12.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_13_col15.clone() - mem_verify_cond_input_value_limb_13.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_14_col16.clone() - mem_verify_cond_input_value_limb_14.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_15_col17.clone() - mem_verify_cond_input_value_limb_15.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_16_col18.clone() - mem_verify_cond_input_value_limb_16.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_17_col19.clone() - mem_verify_cond_input_value_limb_17.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_18_col20.clone() - mem_verify_cond_input_value_limb_18.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_19_col21.clone() - mem_verify_cond_input_value_limb_19.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_20_col22.clone() - mem_verify_cond_input_value_limb_20.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_21_col23.clone() - mem_verify_cond_input_value_limb_21.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_22_col24.clone() - mem_verify_cond_input_value_limb_22.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_23_col25.clone() - mem_verify_cond_input_value_limb_23.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_24_col26.clone() - mem_verify_cond_input_value_limb_24.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_25_col27.clone() - mem_verify_cond_input_value_limb_25.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_26_col28.clone() - mem_verify_cond_input_value_limb_26.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| // felt252 limb is zero. | ||
| eval.add_constraint( | ||
| ((cond_address_limb_27_col29.clone() - mem_verify_cond_input_value_limb_27.clone()) | ||
| * mem_verify_cond_input_cond.clone()), | ||
| ); | ||
| [] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing validation that program fits within bound
Medium Severity
The old code dynamically sized the preprocessed column via
data.len().next_power_of_two(), accommodating any program length. The new code hardcodes the column length to1 << PROGRAM_LOG_LEN_BOUND(4096) but never validates that the actual program length (initial_ap - 2 - initial_pc) fits within this bound. If a program exceeds 4096 entries,ProgramColumn::newsilently truncates the data whileget_program_len()returns the full length, causingdeduce_outputto setcond=1for indices beyond the preprocessed column — a mismatch that could lead to proof failures or incomplete program verification.Additional Locations (1)
stwo_cairo_prover/crates/common/src/preprocessed_columns/program.rs#L58-L74