Skip to content

Paralleize entire circuit write_interaction_trace#322

Open
alon-f wants to merge 1 commit intomainfrom
03-08-paralleize_entire_circuit_write_interaction_trace
Open

Paralleize entire circuit write_interaction_trace#322
alon-f wants to merge 1 commit intomainfrom
03-08-paralleize_entire_circuit_write_interaction_trace

Conversation

@alon-f
Copy link
Copy Markdown
Contributor

@alon-f alon-f commented Mar 8, 2026

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown
Collaborator

This change is Reviewable

@alon-f alon-f marked this pull request as ready for review March 8, 2026 13:19
Copy link
Copy Markdown
Contributor Author

alon-f commented Mar 8, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@alon-f alon-f requested a review from Gali-StarkWare March 8, 2026 13:19
Copy link
Copy Markdown
Contributor

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LMK how much it saves

@Gali-StarkWare made 1 comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved.

Copy link
Copy Markdown
Contributor

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gali-StarkWare reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on alon-f).


crates/circuit_prover/src/witness/trace.rs line 376 at r1 (raw file):

        (range_check_15_trace, range_check_15_interaction_claim),
        (range_check_16_trace, range_check_16_interaction_claim),
    ) = std::thread::scope(|s| {

rayon?

Code quote:

std::thread::scope

Copy link
Copy Markdown
Contributor

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gali-StarkWare made 1 comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on alon-f).


crates/circuit_prover/src/witness/trace.rs line 448 at r1 (raw file):

    });

    tree_builder.extend_evals(eq_trace);

Maybe we can do the interpolation inside the parallel block and then only do extend_polys() after

Copy link
Copy Markdown
Contributor

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gali-StarkWare reviewed 1 file.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on alon-f).

Copy link
Copy Markdown
Contributor

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can close this pr

@Gali-StarkWare made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on alon-f).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants