Paralleize entire circuit write_interaction_trace#322
Conversation
Gali-StarkWare
left a comment
There was a problem hiding this comment.
LMK how much it saves
@Gali-StarkWare made 1 comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved.
Gali-StarkWare
left a comment
There was a problem hiding this comment.
@Gali-StarkWare reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on alon-f).
crates/circuit_prover/src/witness/trace.rs line 376 at r1 (raw file):
(range_check_15_trace, range_check_15_interaction_claim), (range_check_16_trace, range_check_16_interaction_claim), ) = std::thread::scope(|s| {
rayon?
Code quote:
std::thread::scope
Gali-StarkWare
left a comment
There was a problem hiding this comment.
@Gali-StarkWare made 1 comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on alon-f).
crates/circuit_prover/src/witness/trace.rs line 448 at r1 (raw file):
}); tree_builder.extend_evals(eq_trace);
Maybe we can do the interpolation inside the parallel block and then only do extend_polys() after
Gali-StarkWare
left a comment
There was a problem hiding this comment.
@Gali-StarkWare reviewed 1 file.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on alon-f).
Gali-StarkWare
left a comment
There was a problem hiding this comment.
You can close this pr
@Gali-StarkWare made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on alon-f).

No description provided.