Support verification of multiple circuit proofs#334
Open
noam-starkware wants to merge 1 commit intomainfrom
Open
Support verification of multiple circuit proofs#334noam-starkware wants to merge 1 commit intomainfrom
noam-starkware wants to merge 1 commit intomainfrom
Conversation
Collaborator
5cb2170 to
0843c6b
Compare
f00a858 to
b8e5a9b
Compare
b8e5a9b to
785a37d
Compare
785a37d to
faae70f
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit faae70f. Configure here.
faae70f to
225b379
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Changes the circuit-verifier API and core verification flow to iterate over multiple proofs, which could affect soundness/correctness if vector alignment or shared-context assumptions are wrong.
Overview
Extends
verify_circuit/build_verification_circuitto accept vectors ofCircuitConfig,Proof, andCircuitPublicData, and verifies them sequentially in a singleContextvia a newverify_circuit_single_proofhelper.Updates recursion-related tests to use the new multi-proof API and adds a privacy test that verifies a 2-to-1 recursion scenario by proving twice and verifying both proofs together, with basic consistency checks (e.g., shared
pcs_config).Reviewed by Cursor Bugbot for commit 225b379. Bugbot is set up for automated code reviews on this repo. Configure here.