Skip to content

Support verification of multiple circuit proofs#334

Open
noam-starkware wants to merge 1 commit intomainfrom
noamp/support_verification_of_mult_circuit_proofs
Open

Support verification of multiple circuit proofs#334
noam-starkware wants to merge 1 commit intomainfrom
noamp/support_verification_of_mult_circuit_proofs

Conversation

@noam-starkware
Copy link
Copy Markdown

@noam-starkware noam-starkware commented Mar 10, 2026

Note

Medium Risk
Changes the circuit-verifier API and core verification flow to iterate over multiple proofs, which could affect soundness/correctness if vector alignment or shared-context assumptions are wrong.

Overview
Extends verify_circuit / build_verification_circuit to accept vectors of CircuitConfig, Proof, and CircuitPublicData, and verifies them sequentially in a single Context via a new verify_circuit_single_proof helper.

Updates recursion-related tests to use the new multi-proof API and adds a privacy test that verifies a 2-to-1 recursion scenario by proving twice and verifying both proofs together, with basic consistency checks (e.g., shared pcs_config).

Reviewed by Cursor Bugbot for commit 225b379. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown
Collaborator

This change is Reviewable

@noam-starkware noam-starkware force-pushed the noamp/support_verification_of_mult_circuit_proofs branch 2 times, most recently from 5cb2170 to 0843c6b Compare March 11, 2026 10:56
@noam-starkware noam-starkware force-pushed the noamp/support_verification_of_mult_circuit_proofs branch 6 times, most recently from f00a858 to b8e5a9b Compare March 23, 2026 19:48
@noam-starkware noam-starkware force-pushed the noamp/support_verification_of_mult_circuit_proofs branch from b8e5a9b to 785a37d Compare March 26, 2026 13:50
@noam-starkware noam-starkware force-pushed the noamp/support_verification_of_mult_circuit_proofs branch from 785a37d to faae70f Compare April 9, 2026 11:55
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit faae70f. Configure here.

Comment thread crates/circuit_air/src/verify.rs Outdated
@noam-starkware noam-starkware force-pushed the noamp/support_verification_of_mult_circuit_proofs branch from faae70f to 225b379 Compare April 9, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants