Add TripleXor AIR component with full prove+verify#396
Open
alon-f wants to merge 1 commit intoalon/decomposed-gates-preprocessedfrom
Open
Add TripleXor AIR component with full prove+verify#396alon-f wants to merge 1 commit intoalon/decomposed-gates-preprocessedfrom
alon-f wants to merge 1 commit intoalon/decomposed-gates-preprocessedfrom
Conversation
Integrates the auto-generated TripleXor gate AIR into the circuit prover: - New triple_xor component (framework eval, circuit eval, witness trace) - Preprocessed column IDs renamed to match new AIR (triple_xor_input_addr_0/1/2, triple_xor_output_addr, triple_xor_multiplicity) - Padding in finalize_context for triple_xor gates - Full prove+verify test - Updated FIBONACCI_CIRCUIT_PREPROCESSED_ROOT for N_COMPONENTS=17 The old triple_xor_32 component stays alongside (blake_gate depends on it via the TripleXor32 relation). The new triple_xor operates independently through the Gate relation with preprocessed address columns. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
d06f0fc to
8ff8377
Compare
5961d9f to
fd97a69
Compare
fd97a69 to
5961d9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
triple_xor_input_addr_0/1/2,triple_xor_output_addr,triple_xor_multiplicity)Details
The new
triple_xorcomponent coexists with the oldtriple_xor_32:triple_xor_32: Fed by blake_gate via the TripleXor32 relation (990559919), uses Enabler patterntriple_xor: Independent, uses Gate relation (378353459) with preprocessed address columns and multiplicitiesThis follows the same integration pattern as the M31ToU32 component.
Test plan
triple_xor::tests::test_evaluation_result)test_prove_and_stark_verify_triple_xor_context)FIBONACCI_CIRCUIT_PREPROCESSED_ROOT🤖 Generated with Claude Code
Note
Medium Risk
Adds a new AIR component into the end-to-end proving/verification pipeline and changes preprocessed trace column IDs/roots, which is sensitive to component ordering and lookup wiring but remains scoped to a single new gate type.
Overview
Adds a new independent
triple_xorAIR/component (trace+interaction) alongside existingtriple_xor_32, including constraint evaluation, witness generation, and registration in the component list used by both prover and circuit verifier.Updates TripleXor preprocessed column IDs to the new
triple_xor_input_addr_0/1/2,triple_xor_output_addr, andtriple_xor_multiplicitynaming, adds circuit finalization padding fortriple_xorgates, and extends trace/interaction trace generation and component-prover enumeration accordingly.Extends tests with a full prove+STARK-verify path for a synthetic TripleXor circuit, adds a
TRIPLE_XOR_SAMPLE_EVAL_RESULTevaluation fixture, and updates the expected Fibonacci preprocessed root to reflect the new component/column layout.Written by Cursor Bugbot for commit 5961d9f. This will update automatically on new commits. Configure here.