Skip to content

Use im instead of conj in compute_fri_input.#414

Open
dancarmoz wants to merge 1 commit intomainfrom
danc/im_instead_of_conj
Open

Use im instead of conj in compute_fri_input.#414
dancarmoz wants to merge 1 commit intomainfrom
danc/im_instead_of_conj

Conversation

@dancarmoz
Copy link
Copy Markdown
Collaborator

@dancarmoz dancarmoz commented Mar 23, 2026

Note that conj is not currently used anywhere else.


Note

Medium Risk
Touches core verifier arithmetic used to construct FRI inputs; small but correctness-critical changes could invalidate proofs or break interoperability if the algebra doesn’t exactly match the prover.

Overview
Updates the STARK verifier’s compute_fri_input/OodsPointAuxiliary batching math to use the twisted imaginary part im(z) (instead of z - conj(z) / conj(z)), simplifying accumulators and changing the a/b/c/d/e coefficient definitions used in the rational function.

Adds a new circuit op im (with tests) and rewires oods.rs to depend on it, and updates privacy verifier constant hashes to match the new circuit/verifier constants.

Written by Cursor Bugbot for commit 9fe2f46. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link
Copy Markdown
Collaborator

This change is Reviewable

@dancarmoz dancarmoz force-pushed the danc/im_instead_of_conj branch from 4cb3ac7 to 10956f4 Compare March 23, 2026 14:35
Copy link
Copy Markdown
Contributor

@leo-starkware leo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leo-starkware made 1 comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on dancarmoz and ilyalesokhin-starkware).


crates/stark_verifier/src/oods.rs line 260 at r2 (raw file):

}

/// A struct for handling auxiliary values related OODS data corresponding to a point `(px, py)`.

related to

Code quote:

related OODS

@dancarmoz dancarmoz force-pushed the danc/im_instead_of_conj branch 2 times, most recently from 3eb87b0 to 9bf9c5b Compare March 25, 2026 09:48
Copy link
Copy Markdown
Collaborator Author

@dancarmoz dancarmoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dancarmoz made 1 comment and resolved 1 discussion.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on ilyalesokhin-starkware).


crates/stark_verifier/src/oods.rs line 260 at r2 (raw file):

Previously, leo-starkware wrote…

related to

Done

Copy link
Copy Markdown
Contributor

@leo-starkware leo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@leo-starkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ilyalesokhin-starkware).

@dancarmoz dancarmoz force-pushed the danc/im_instead_of_conj branch from 9bf9c5b to 97bdef4 Compare March 25, 2026 13:19
Note that `conj` is not currently used anywhere else.
@dancarmoz dancarmoz force-pushed the danc/im_instead_of_conj branch from 97bdef4 to 9fe2f46 Compare March 26, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants