Conversation
4cb3ac7 to
10956f4
Compare
leo-starkware
left a comment
There was a problem hiding this comment.
@leo-starkware made 1 comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on dancarmoz and ilyalesokhin-starkware).
crates/stark_verifier/src/oods.rs line 260 at r2 (raw file):
} /// A struct for handling auxiliary values related OODS data corresponding to a point `(px, py)`.
related to
Code quote:
related OODS3eb87b0 to
9bf9c5b
Compare
dancarmoz
left a comment
There was a problem hiding this comment.
@dancarmoz made 1 comment and resolved 1 discussion.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on ilyalesokhin-starkware).
crates/stark_verifier/src/oods.rs line 260 at r2 (raw file):
Previously, leo-starkware wrote…
related to
Done
leo-starkware
left a comment
There was a problem hiding this comment.
@leo-starkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ilyalesokhin-starkware).
9bf9c5b to
97bdef4
Compare
Note that `conj` is not currently used anywhere else.
97bdef4 to
9fe2f46
Compare
Note that
conjis not currently used anywhere else.Note
Medium Risk
Touches core verifier arithmetic used to construct FRI inputs; small but correctness-critical changes could invalidate proofs or break interoperability if the algebra doesn’t exactly match the prover.
Overview
Updates the STARK verifier’s
compute_fri_input/OodsPointAuxiliarybatching math to use the twisted imaginary partim(z)(instead ofz - conj(z)/conj(z)), simplifying accumulators and changing thea/b/c/d/ecoefficient definitions used in the rational function.Adds a new circuit op
im(with tests) and rewiresoods.rsto depend on it, and updates privacy verifier constant hashes to match the new circuit/verifier constants.Written by Cursor Bugbot for commit 9fe2f46. This will update automatically on new commits. Configure here.