Move seq_of_component_size into ComponentDataTrait#450
Move seq_of_component_size into ComponentDataTrait#450noa-starkware wants to merge 1 commit intonoa/narrower-arg-seq-of-component-sizefrom
Conversation
PR SummaryMedium Risk Overview Removes the now-redundant Reviewed by Cursor Bugbot for commit d6e8eea. Bugbot is set up for automated code reviews on this repo. Configure here. |
23ca5ad to
3e71667
Compare
e628619 to
660bde1
Compare
3e71667 to
3e1307c
Compare
660bde1 to
36dc977
Compare
Add seq_of_component_size as a default method on ComponentDataTrait, removing the free functions in component_utils and the now-empty modules. Call sites updated to method syntax. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3e1307c to
d6e8eea
Compare
|
Suggestion: circuits::ops::eq(context, sum_bits, context.one()); |
|
I think the motivation for moving this function was to avoid this abstraction. Code quote: let bit = self.get_n_instances_bit(context, log_size); |
Summary
seq_of_component_sizeis now a default method onComponentDataTraitinstark_verifiercomponent_utilsmodules incairo_airandcircuit_aircomponent_data.seq_of_component_size(...)Stacks on #449. Part of audit cleanup (ilya/audit2 TODO comments).
🤖 Generated with Claude Code