Skip to content

为 deepseek-harness 声明截图 - #35

Merged
starsstreaming merged 1 commit into
mainfrom
chore/deepseek-harness-screenshots
Aug 26, 2026
Merged

为 deepseek-harness 声明截图#35
starsstreaming merged 1 commit into
mainfrom
chore/deepseek-harness-screenshots

Conversation

@starsstreaming

@starsstreaming starsstreaming commented Aug 26, 2026

Copy link
Copy Markdown
Owner

变更说明

  • 在 monorepo 子包 integrations/deepseek-harness/ 新增 screenshots.json
  • 声明现有两张 GitHub 托管截图
  • 不修改插件运行时代码

验证

  • JSON 解析通过
  • git diff --check 通过

这是对 awesome-dsh-plugin PR #1834 中新截图约定的跟进。

Summary by CodeRabbit

  • 文档
    • 新增两个 GitHub 用户附件截图链接,便于查看相关视觉资料。

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7837f4a6-8e41-4485-81e4-490e42876a7d

📥 Commits

Reviewing files that changed from the base of the PR and between 365ec5c and f6f91a8.

📒 Files selected for processing (1)
  • integrations/deepseek-harness/screenshots.json

📝 Walkthrough

Walkthrough

新增 screenshots.json,用于记录两个 GitHub 用户附件截图 URL。

Changes

截图资源

Layer / File(s) Summary
新增截图清单
integrations/deepseek-harness/screenshots.json
新增包含两个截图资源 URL 的 JSON 数组。

Estimated code review effort: 1(简单)| ~2 分钟

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/deepseek-harness-screenshots

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@starsstreaming
starsstreaming merged commit 5d42fd8 into main Aug 26, 2026
8 of 9 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f6f91a8327

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -0,0 +1,4 @@
[

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include the screenshot manifest in published packages

When screenshot metadata is read from the published plugin, this new manifest is unavailable: integrations/deepseek-harness/package.json has a restrictive files list that omits screenshots.json, and the release pipeline in scripts/pack-dsh-plugin.mjs separately copies only PLUGIN_FILES, which also omits it. Consequently, both direct npm pack and npm run plugin:publish exclude the manifest, so the screenshot convention this commit implements cannot work for package consumers; add it to both publication allowlists.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant