Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Tweak collection & form widgets border style in light mode #10426

Merged
merged 27 commits into from
Jul 10, 2024
Merged

[5.x] Tweak collection & form widgets border style in light mode #10426

merged 27 commits into from
Jul 10, 2024

Conversation

rezbouchabou
Copy link
Contributor

@rezbouchabou rezbouchabou commented Jul 10, 2024 •
edited by duncanmcclean
Loading

Before:
before

After:
after

Fixes #10396.

rezbouchabou and others added 24 commits July 3, 2024 23:12
duncanmcclean
duncanmcclean reviewed Jul 10, 2024
View reviewed changes
Copy link
Member

@duncanmcclean duncanmcclean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth adding the border to the form submissions widget too:

CleanShot 2024-07-10 at 13 14 17

@rezbouchabou rezbouchabou marked this pull request as draft July 10, 2024 12:26
@rezbouchabou rezbouchabou changed the title [5.x] Tweak collection widget border style in light mode [5.x] Tweak collection & form widget border style in light mode Jul 10, 2024
rezbouchabou
rezbouchabou commented Jul 10, 2024
View reviewed changes
Copy link
Contributor Author

@rezbouchabou rezbouchabou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweak collection & form widget border style in light mode

@rezbouchabou rezbouchabou changed the title [5.x] Tweak collection & form widget border style in light mode [5.x] Tweak collection & form widgets border style in light mode Jul 10, 2024
@rezbouchabou rezbouchabou marked this pull request as ready for review July 10, 2024 13:25
@jasonvarga jasonvarga merged commit a39cadd into statamic:5.x Jul 10, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanmcclean duncanmcclean duncanmcclean left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collection widget with custom fields miss a border above the table header
3 participants
@rezbouchabou @duncanmcclean @jasonvarga